Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field

Lee Jones
2015-05-05T10:54:52Z

On Tue, 05 May 2015, Javier Martinez Canillas wrote:
> On 04/29/2015 12:37 PM, Lee Jones wrote:
> > On Thu, 23 Apr 2015, Gwendal Grignou wrote:
> >
> >> Be consistent, use cros_ec instead of "cros ec" or "cros-ec".
> >
> > What is this in reference to?
> >
>
> I think Gwendal meant that I should be consistent in general and was not
> referring to this patch particular.

Better to quote one of the offending occurrences than to randomly
top-post helpful comments.

> >> Otherwise:
> >>
> >> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
> >> Tested-by: Gwendal Grignou <gwendal@chromium.org>
> >>
> >> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas
> >> <javier.martinez@collabora.co.uk> wrote:
> >> > From: Gwendal Grignou <gwendal@chromium.org>
> >> >
> >> > parent and dev were pointing to the same device structure.
> >> > parent is unused, removed.
> >> >
> >> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> >> > Reviewed-by: Stephen Barber <smbarber@chromium.org>
> >> > Tested-by: Stephen Barber <smbarber@chromium.org>
> >> > Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>
> >> > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> >> > ---
> >> > drivers/mfd/cros_ec_i2c.c | 1 -
> >> > drivers/mfd/cros_ec_spi.c | 1 -
> >> > drivers/platform/chrome/cros_ec_lpc.c | 1 -
> >> > include/linux/mfd/cros_ec.h | 2 --
> >> > 4 files changed, 5 deletions(-)
> >
> > For when you re-submit:
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
>
> Thanks a lot for your ack.
>
> Best regards,
> Javier

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog