public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>,
	konrad.wilk@oracle.com, hpa@zytor.com, mingo@redhat.com,
	tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux@eikelenboom.it, luto@amacapital.net
Subject: Re: [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests
Date: Tue, 05 May 2015 13:31:08 -0400	[thread overview]
Message-ID: <5548FE5C.80609@oracle.com> (raw)
In-Reply-To: <5548FD26.8080906@citrix.com>

On 05/05/2015 01:25 PM, David Vrabel wrote:
> On 04/05/15 16:02, Boris Ostrovsky wrote:
>> --- a/arch/x86/xen/enlighten.c
>> +++ b/arch/x86/xen/enlighten.c
>> @@ -1760,6 +1760,9 @@ static struct notifier_block xen_hvm_cpu_notifier = {
>>   
>>   static void __init xen_hvm_guest_init(void)
>>   {
>> +	if (xen_pv_domain())
>> +		return;
>> +
> I take Andy's point that this looks a little odd, perhaps...
>
> static void __init xen_platform_init(void)
> {
>      if (!xen_pv_domain())
>          xen_hvm_guest_init();
> }
>
> Would be a useful follow up?
>
> I'll apply as-is though
>


Yes, this would look better. I can respin this if you want to avoid the 
extra patch.

-boris

      reply	other threads:[~2015-05-05 17:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 15:02 [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests Boris Ostrovsky
2015-05-05 13:51 ` Andy Lutomirski
2015-05-05 14:21   ` Boris Ostrovsky
2015-05-05 17:25 ` David Vrabel
2015-05-05 17:31   ` Boris Ostrovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5548FE5C.80609@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox