public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Badhri Jagan Sridharan <badhri@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Adds handler name to irq_handler_entry
Date: Tue, 05 May 2015 20:08:15 -0700	[thread overview]
Message-ID: <5549859F.4020706@google.com> (raw)
In-Reply-To: <20150505214619.14a60669@grimm.local.home>

Done!!
Uploaded a new patch v2.

On 05/05/2015 06:46 PM, Steven Rostedt wrote:
> On Tue,  5 May 2015 17:46:58 -0700
> Badhri Jagan Sridharan <badhri@google.com> wrote:
>
>> This patch includes the ISR function name to
>> irq_handler_entry trace point.
>>
>> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
>> ---
>>   include/trace/events/irq.h | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
>> index ff8f6c0..9994ba4 100644
>> --- a/include/trace/events/irq.h
>> +++ b/include/trace/events/irq.h
>> @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry,
>>   	TP_STRUCT__entry(
>>   		__field(	int,	irq		)
>>   		__string(	name,	action->name	)
>> +		__field(void*,	handler)
>
> Please follow the format that the other fields have. This isn't a
> function call to use the "checkpatch" version of indentation.
>
> 		__field(	void *,	handler		)
>
> -- Steve
>
>>   	),
>>
>>   	TP_fast_assign(
>>   		__entry->irq = irq;
>>   		__assign_str(name, action->name);
>> +		__entry->handler = action->handler;
>>   	),
>>
>> -	TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
>> +	TP_printk("irq=%d name=%s handler=%pf",
>> +		__entry->irq, __get_str(name), __entry->handler)
>>   );
>>
>>   /**
>

      reply	other threads:[~2015-05-06  3:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  0:46 [PATCH] tracing: Adds handler name to irq_handler_entry Badhri Jagan Sridharan
2015-05-06  1:46 ` Steven Rostedt
2015-05-06  3:08   ` Badhri Jagan Sridharan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5549859F.4020706@google.com \
    --to=badhri@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox