* [PATCH] tracing: Adds handler name to irq_handler_entry
@ 2015-05-06 0:46 Badhri Jagan Sridharan
2015-05-06 1:46 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Badhri Jagan Sridharan @ 2015-05-06 0:46 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: linux-kernel, Badhri Jagan Sridharan
This patch includes the ISR function name to
irq_handler_entry trace point.
Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
---
include/trace/events/irq.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
index ff8f6c0..9994ba4 100644
--- a/include/trace/events/irq.h
+++ b/include/trace/events/irq.h
@@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry,
TP_STRUCT__entry(
__field( int, irq )
__string( name, action->name )
+ __field(void*, handler)
),
TP_fast_assign(
__entry->irq = irq;
__assign_str(name, action->name);
+ __entry->handler = action->handler;
),
- TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
+ TP_printk("irq=%d name=%s handler=%pf",
+ __entry->irq, __get_str(name), __entry->handler)
);
/**
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tracing: Adds handler name to irq_handler_entry
2015-05-06 0:46 [PATCH] tracing: Adds handler name to irq_handler_entry Badhri Jagan Sridharan
@ 2015-05-06 1:46 ` Steven Rostedt
2015-05-06 3:08 ` Badhri Jagan Sridharan
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2015-05-06 1:46 UTC (permalink / raw)
To: Badhri Jagan Sridharan; +Cc: Ingo Molnar, linux-kernel
On Tue, 5 May 2015 17:46:58 -0700
Badhri Jagan Sridharan <badhri@google.com> wrote:
> This patch includes the ISR function name to
> irq_handler_entry trace point.
>
> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
> ---
> include/trace/events/irq.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
> index ff8f6c0..9994ba4 100644
> --- a/include/trace/events/irq.h
> +++ b/include/trace/events/irq.h
> @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry,
> TP_STRUCT__entry(
> __field( int, irq )
> __string( name, action->name )
> + __field(void*, handler)
Please follow the format that the other fields have. This isn't a
function call to use the "checkpatch" version of indentation.
__field( void *, handler )
-- Steve
> ),
>
> TP_fast_assign(
> __entry->irq = irq;
> __assign_str(name, action->name);
> + __entry->handler = action->handler;
> ),
>
> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
> + TP_printk("irq=%d name=%s handler=%pf",
> + __entry->irq, __get_str(name), __entry->handler)
> );
>
> /**
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tracing: Adds handler name to irq_handler_entry
2015-05-06 1:46 ` Steven Rostedt
@ 2015-05-06 3:08 ` Badhri Jagan Sridharan
0 siblings, 0 replies; 3+ messages in thread
From: Badhri Jagan Sridharan @ 2015-05-06 3:08 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Ingo Molnar, linux-kernel
Done!!
Uploaded a new patch v2.
On 05/05/2015 06:46 PM, Steven Rostedt wrote:
> On Tue, 5 May 2015 17:46:58 -0700
> Badhri Jagan Sridharan <badhri@google.com> wrote:
>
>> This patch includes the ISR function name to
>> irq_handler_entry trace point.
>>
>> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
>> ---
>> include/trace/events/irq.h | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
>> index ff8f6c0..9994ba4 100644
>> --- a/include/trace/events/irq.h
>> +++ b/include/trace/events/irq.h
>> @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry,
>> TP_STRUCT__entry(
>> __field( int, irq )
>> __string( name, action->name )
>> + __field(void*, handler)
>
> Please follow the format that the other fields have. This isn't a
> function call to use the "checkpatch" version of indentation.
>
> __field( void *, handler )
>
> -- Steve
>
>> ),
>>
>> TP_fast_assign(
>> __entry->irq = irq;
>> __assign_str(name, action->name);
>> + __entry->handler = action->handler;
>> ),
>>
>> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
>> + TP_printk("irq=%d name=%s handler=%pf",
>> + __entry->irq, __get_str(name), __entry->handler)
>> );
>>
>> /**
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-06 3:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-06 0:46 [PATCH] tracing: Adds handler name to irq_handler_entry Badhri Jagan Sridharan
2015-05-06 1:46 ` Steven Rostedt
2015-05-06 3:08 ` Badhri Jagan Sridharan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox