Re: [PATCH] tracing: Adds handler name to irq_handler_entry

Badhri Jagan Sridharan
2015-05-06T03:08:21Z

Done!!
Uploaded a new patch v2.

On 05/05/2015 06:46 PM, Steven Rostedt wrote:
> On Tue, 5 May 2015 17:46:58 -0700
> Badhri Jagan Sridharan <badhri@google.com> wrote:
>
>> This patch includes the ISR function name to
>> irq_handler_entry trace point.
>>
>> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
>> ---
>> include/trace/events/irq.h | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
>> index ff8f6c0..9994ba4 100644
>> --- a/include/trace/events/irq.h
>> +++ b/include/trace/events/irq.h
>> @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry,
>> TP_STRUCT__entry(
>> __field( int, irq )
>> __string( name, action->name )
>> + __field(void*, handler)
>
> Please follow the format that the other fields have. This isn't a
> function call to use the "checkpatch" version of indentation.
>
> __field( void *, handler )
>
> -- Steve
>
>> ),
>>
>> TP_fast_assign(
>> __entry->irq = irq;
>> __assign_str(name, action->name);
>> + __entry->handler = action->handler;
>> ),
>>
>> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
>> + TP_printk("irq=%d name=%s handler=%pf",
>> + __entry->irq, __get_str(name), __entry->handler)
>> );
>>
>> /**
>