From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751698AbbEFJK7 (ORCPT ); Wed, 6 May 2015 05:10:59 -0400 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:43174 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbbEFJKz (ORCPT ); Wed, 6 May 2015 05:10:55 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <5549DA9B.6030700@mev.co.uk> Date: Wed, 06 May 2015 10:10:51 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: nick CC: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, chase.southwood@gmail.com, ebru.akagunduz@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: Question about the function,ni_stc_dma_channel_select_bitfield References: <55495EA8.2090902@gmail.com> In-Reply-To: <55495EA8.2090902@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/15 01:22, nick wrote: > Greetings All, > I am wondering if in the function,ni_stc_dma_channel_select_bitfield the line: > return 1 << channel; > is guaranteed to be below the threshold that guarantees us to not overflow on > a unsigned 32 integer due to bit wise shifting to the left. > Thanks Nick > if (channel < 4) return 1 << channel; So, yes. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-