public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Stephen Boyd <sboyd@codeaurora.org>,
	Mike Turquette <mturquette@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 03/19] clk: max-gen: Silence sparse warnings
Date: Wed, 06 May 2015 11:23:20 +0200	[thread overview]
Message-ID: <5549DD88.1010803@collabora.co.uk> (raw)
In-Reply-To: <1430897996-11597-4-git-send-email-sboyd@codeaurora.org>

Hello Stephen,

On 05/06/2015 09:39 AM, Stephen Boyd wrote:
> drivers/clk/clk-max-gen.c:82:16: warning: symbol 'max_gen_clk_ops' was not declared. Should it be static?
> drivers/clk/clk-max-gen.c:109:5: warning: symbol 'max_gen_clk_probe' was not declared. Should it be static?
> drivers/clk/clk-max-gen.c:183:5: warning: symbol 'max_gen_clk_remove' was not declared. Should it be static?
> 
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>  drivers/clk/clk-max-gen.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/clk-max-gen.c b/drivers/clk/clk-max-gen.c
> index 6505049d50f1..35af9cb6da4f 100644
> --- a/drivers/clk/clk-max-gen.c
> +++ b/drivers/clk/clk-max-gen.c
> @@ -31,6 +31,8 @@
>  #include <linux/of.h>
>  #include <linux/export.h>
>  
> +#include "clk-max-gen.h"
> +
>  struct max_gen_clk {
>  	struct regmap *regmap;
>  	u32 mask;
> 

Looks good to me.

Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier

  reply	other threads:[~2015-05-06  9:23 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  7:39 [PATCH 00/19] Fix sparse errors in drivers/clk/ Stephen Boyd
2015-05-06  7:39 ` [PATCH 01/19] clk: gpio-gate: Don't export __init functions Stephen Boyd
2015-05-06  7:39 ` [PATCH 02/19] clk: Silence sparse warnings about __clk_{get,put}() Stephen Boyd
2015-05-06  7:39 ` [PATCH 03/19] clk: max-gen: Silence sparse warnings Stephen Boyd
2015-05-06  9:23   ` Javier Martinez Canillas [this message]
2015-05-06  7:39 ` [PATCH 04/19] clk: bcm/kona: " Stephen Boyd
2015-05-06 13:21   ` Alex Elder
2015-05-06  7:39 ` [PATCH 05/19] clk: bcm/kona: Remove ccu_list Stephen Boyd
2015-05-06 13:23   ` Alex Elder
2015-05-06  7:39 ` [PATCH 06/19] clk: berlin: Silence sparse warning Stephen Boyd
2015-05-06 22:28   ` Sebastian Hesselbarth
2015-05-06  7:39 ` [PATCH 07/19] clk: hix5hd2: Silence sparse warnings Stephen Boyd
2015-05-06  8:55   ` zhangfei
2015-05-06  7:39 ` [PATCH 08/19] clk: samsung: " Stephen Boyd
2015-05-06 10:53   ` Sylwester Nawrocki
2015-05-06  7:39 ` [PATCH 09/19] clk: emev2: " Stephen Boyd
2015-05-07  4:36   ` Simon Horman
2015-05-07  5:17     ` Stephen Boyd
2015-05-07  5:31       ` Simon Horman
2015-05-06  7:39 ` [PATCH 10/19] clk: sirf: " Stephen Boyd
2015-05-06  7:39 ` [PATCH 11/19] clk: socfpga: Silence sparse warning Stephen Boyd
2015-05-06  7:39 ` [PATCH 12/19] clk: st: Silence sparse warnings Stephen Boyd
2015-05-06  7:39 ` [PATCH 13/19] clk: ti: " Stephen Boyd
2015-05-06  8:15   ` Peter Ujfalusi
2015-05-07  8:16     ` Tero Kristo
2015-05-06  7:39 ` [PATCH 14/19] clk: versatile: " Stephen Boyd
2015-05-06 10:31   ` Pawel Moll
2015-05-06  7:39 ` [PATCH 15/19] clk: socfpga: Silence sparse warning Stephen Boyd
2015-05-06  7:39 ` [PATCH 16/19] clk: mmp: Silence sparse warnings Stephen Boyd
2015-05-06  7:39 ` [PATCH 17/19] clk: xgene: " Stephen Boyd
2015-05-06  7:39 ` [PATCH 18/19] clk: moxart: " Stephen Boyd
2015-05-06  7:39 ` [PATCH 19/19] clk: u300: " Stephen Boyd
2015-05-12 10:38   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5549DD88.1010803@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox