From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752459AbbEFNpb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 May 2015 09:45:31 -0400
Received: from mout.web.de ([212.227.15.3]:54037 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750808AbbEFNpa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 May 2015 09:45:30 -0400
Message-ID: <554A1AF3.9010802@users.sourceforge.net>
Date: Wed, 06 May 2015 15:45:23 +0200
From: SF Markus Elfring <elfring@users.sourceforge.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Julia Lawall <julia.lawall@lip6.fr>
CC: Andrew Morton <akpm@linux-foundation.org>,
        Coccinelle <cocci@systeme.lip6.fr>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Fabian Frederick <fabf@skynet.be>,
        Joe Perches <joe@perches.com>
Subject: Re: [patch 119/197] scripts/coccinelle/free: Delete NULL test before
 freeing functions
References: <53e53fd1.zO3IbUqJ421c7VXf%akpm@linux-foundation.org> <53E5DA60.90902@users.sourceforge.net> <alpine.DEB.2.02.1408091028520.2016@localhost6.localdomain6>
In-Reply-To: <alpine.DEB.2.02.1408091028520.2016@localhost6.localdomain6>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:2rL55fZZC330YLHOHkbtFJcuNNY2Ko4tzfh8+oXLHJ16367BpHH
 vULzFkuAYkqfHKekM1XDQOYMHLaQ3NRUJCM2zZsbqnRNYp/7muJuCQbBcP6Y9XUhZiHFz1W
 waSr3KVi2Bg86mXfpNRg9fFn5hd2x/mVUl95PMrXGrebJ89R4fQHAZA+BWDrHChmS1yP73k
 MBqGZCw4gMyjRCtb2xXwg==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> +@r depends on context || report || org @
>>> +expression E;
>>> +position p;
>>> +@@
>>> +
>>> +* if (E)
>>> +*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);
>>
>> How do you think about to add the construct "@p" also behind the function name
>> "usb_free_urb"?
> 
> Yes, that would be needed, thanks.  Also, it was recently suggested to add 
> of_node_put to the list of things that are checked for.

Would you like to achieve further improvements for this approach?
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/scripts/coccinelle/free/ifnullfree.cocci?id=refs/tags/v4.0.1#n34

Regards,
Markus