From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbbEFOXx (ORCPT ); Wed, 6 May 2015 10:23:53 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:35095 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752123AbbEFOXw (ORCPT ); Wed, 6 May 2015 10:23:52 -0400 Message-ID: <554A23F4.7010004@kernel.dk> Date: Wed, 06 May 2015 08:23:48 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Linus Torvalds , Herbert Xu CC: Christophe Leroy , Al Viro , Linux Kernel Mailing List , linux-fsdevel , Linux Crypto Mailing List Subject: Re: [PATCH v2] splice: sendfile() at once fails for big files References: <20150423150308.8782B1A2439@localhost.localdomain> <20150427070131.GA21190@gondor.apana.org.au> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2015 09:41 PM, Linus Torvalds wrote: > Jens, ping? > > The test results should make this a no-brainer, but I hate how random > these flag ops. Missed the original, apparently. I too am confused how this is a correctness fix and not just an optimization. + if (read_len < len) + sd->flags |= SPLICE_F_MORE; + else if (!more) + sd->flags &= ~SPLICE_F_MORE; Should that check be for 'more', not '!more'? -- Jens Axboe