Re: [PATCH V2] Test compaction of mlocked memory

[Sri <sjayaram@akamai.com>]

Hi Shuah,

This is what I see when I check the patch against the script,

linux-stable$ ./scripts/checkpatch.pl
0001-Test-compaction-of-mlocked-memory.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#72:
new file mode 100644

total: 0 errors, 1 warnings, 256 lines checked

0001-Test-compaction-of-mlocked-memory.patch has style problems, please
review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


That was the only warning I saw even before I submitted the patch. I'm
not sure how the whitespaces are introduced...

Thanks

-Sri


On 05/06/2015 01:01 PM, Shuah Khan wrote:
> On 04/23/2015 02:24 PM, Shuah Khan wrote:
>> On 04/23/2015 02:23 PM, Andrew Morton wrote:
>>> On Thu, 23 Apr 2015 14:41:34 -0400 Eric B Munson <emunson@akamai.com> wrote:
>>>
>>>> On Thu, 23 Apr 2015, Sri Jayaramappa wrote:
>>>>
>>>>> Commit commit 5bbe3547aa3b ("mm: allow compaction of unevictable pages")
>>>>> introduced a sysctl that allows userspace to enable scanning of locked
>>>>> pages for compaction.  This patch introduces a new test which fragments
>>>>> main memory and attempts to allocate a number of huge pages to exercise
>>>>> this compaction logic.
>>>>>
>>>>> Tested on machines with up to 32 GB RAM. With the patch a much larger
>>>>> number of huge pages can be allocated than on the kernel without the
>>>>> patch.
>>>>>
>>>>> Example output:
>>>>> On a machine with 16 GB RAM:
>>>>> sudo make run_tests vm
>>>>> ...
>>>>> -----------------------
>>>>> running compaction_test
>>>>> -----------------------
>>>>> No of huge pages allocated = 3834
>>>>> [PASS]
>>>>> ...
>>>>>
>>>>> Signed-off-by: Sri Jayaramappa <sjayaram@akamai.com>
>>>>> Cc: linux-kernel@vger.kernel.org
>>>>> Cc: linux-api@vger.kernel.org
>>>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>>>> Cc: Eric B Munson <emunson@akamai.com>
>>>>
>>>> Reviewed-by: Eric B Munson <emunson@akamai.com>
>>>
>>> Acked-by: Andrew Morton <akpm@linux-foundation.org>
>>>
>>> I'm assuming that Shuah will process this one?
>>>
>>
>> Yes. I will get this one after the merge window closes.
>>
> 
> Hi Sri Jayaramappa,
> 
> The patch didn't pass checkpatch. Several trailing whitespace
> errors. Could you please fix these and resend.
> 
> thanks,
> -- Shuah
> 
>