[PATCH v4 5/7] selftest/x86: have no dependency on all when cross building

[PATCH v4 5/7] selftest/x86: have no dependency on all when cross building

[Tyler Baker]

If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.

Cc: Andy Lutomirski <luto@amacapital.net>
Acked-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
 tools/testing/selftests/x86/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index be93945..ec7b088 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -7,15 +7,18 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
 
 CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
 
+all:
+
 UNAME_M := $(shell uname -m)
 
+ifeq ($(CROSS_COMPILE),)
 # Always build 32-bit tests
 all: all_32
-
 # If we're on a 64-bit host, build 64-bit tests as well
 ifeq ($(UNAME_M),x86_64)
 all: all_64
 endif
+endif
 
 all_32: check_build32 $(BINARIES_32)
 
-- 
2.1.4

Re: [PATCH v4 5/7] selftest/x86: have no dependency on all when cross building

[Shuah Khan]

On 04/21/2015 04:51 PM, Tyler Baker wrote:
> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
> 
> Cc: Andy Lutomirski <luto@amacapital.net>
> Acked-by: Andy Lutomirski <luto@kernel.org>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---

I will wait on this patch and other x85 patches in this series
until x86 always build 32 breaking make kselftest target.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978