From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbbEGJbj (ORCPT ); Thu, 7 May 2015 05:31:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47317 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbbEGJbh (ORCPT ); Thu, 7 May 2015 05:31:37 -0400 Message-ID: <554B30F1.506@redhat.com> Date: Thu, 07 May 2015 11:31:29 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Heiko Carstens CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: remove pointless cpu hotplug messages References: <1430811548-34140-1-git-send-email-heiko.carstens@de.ibm.com> In-Reply-To: <1430811548-34140-1-git-send-email-heiko.carstens@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2015 09:39, Heiko Carstens wrote: > On cpu hotplug only KVM emits an unconditional message that its notifier > has been called. It certainly can be assumed that calling cpu hotplug > notifiers work, therefore there is no added value if KVM prints a message. > > If an error happens on cpu online KVM will still emit a warning. > > So let's remove this superfluous message. > > Signed-off-by: Heiko Carstens > --- > virt/kvm/kvm_main.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 90977418aeb6..5fb52af5b975 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2882,18 +2882,12 @@ static int hardware_enable_all(void) > static int kvm_cpu_hotplug(struct notifier_block *notifier, unsigned long val, > void *v) > { > - int cpu = (long)v; > - > val &= ~CPU_TASKS_FROZEN; > switch (val) { > case CPU_DYING: > - pr_info("kvm: disabling virtualization on CPU%d\n", > - cpu); > hardware_disable(); > break; > case CPU_STARTING: > - pr_info("kvm: enabling virtualization on CPU%d\n", > - cpu); > hardware_enable(); > break; > } > Applied, thanks. Paolo