From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752224AbbEGMjY (ORCPT ); Thu, 7 May 2015 08:39:24 -0400 Received: from mx6-out12.antispamcloud.com ([95.211.2.203]:54092 "EHLO mx6-out12.antispamcloud.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbEGMjV convert rfc822-to-8bit (ORCPT ); Thu, 7 May 2015 08:39:21 -0400 X-Greylist: delayed 1908 seconds by postgrey-1.27 at vger.kernel.org; Thu, 07 May 2015 08:39:20 EDT Message-ID: <554B557D.10005@topic.nl> Date: Thu, 7 May 2015 14:07:25 +0200 From: Mike Looijmans Organization: TOPIC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: CC: , Subject: Re: [PATCH] arm/mm/dma-mapping.c: Add arm_coherent_dma_mmap References: <1431000019-7483-1-git-send-email-mike.looijmans@topic.nl> In-Reply-To: <1431000019-7483-1-git-send-email-mike.looijmans@topic.nl> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8BIT X-Originating-IP: [192.168.80.121] X-EXCLAIMER-MD-CONFIG: 9833cda7-5b21-4d34-9a38-8d025ddc3664 X-EXCLAIMER-MD-BIFURCATION-INSTANCE: 0 X-Filter-ID: s0sct1PQhAABKnZB5plbIbbvfIHzQjPVmPLZeVYSu3xU9luQrU+8/8qthi+0Jd/W6KAUC/fjyuDn NXFr4uarw1HLdaqPQEXQbVxseDCsCCuAv7TlYyOHVsk7300Fxo0/mhHwuZkwbQpbZ8u+YNzCrubu uaY6h7+p6gYbXP93yipdvBbaICrMNnSf5QZcuDddHaaU/Zb275qB1xqcfpxQM04ZRLAR5Nk6pwhC s6c5v+JNYOiVzWVTWXoOblrTxyZlDKc0WsOGY2k/NyywqOvOpsJFQn+BSyBw9TE8tTCbymZm4zuN RcgRKiGg7nXFaZTxoKQSO8nX5qkMFsHcSQtpZSFFpIm0oOZDRDp3kekWSIO7pJm4TGa91RQsOc1N ABY5mdySlZou9qHIGOZDEEo7Oxej1XuGiHCiRIaTxIqPAjGeaBhNn0PAwtVe3042wgO0SvmQIYQ6 RRUQYVLkKUE+dtM+m4WpRRDP6YzwkAPgQJZd3Kg1y3YSA3E1cxAs+Je+e2Z+jhkHEy3JftdEtggk hZFiaxHtpDuuW5bdAVpJRg1N0+HffnE5rsYCyTZrr6BqVgW9/bktU41htiJ8fk7NkLCnEF6R8eu6 eRsYrCDZD0m+7uydbHntxzcqrxKUj7m0KzclebW8UZtqN7hHb0IKQfDNqFK6+NmCo1VRk6W3p0my z09PdTVE+Ojr9i+SCZxU6BczixKau3SVCHUjX//Ej2qqxUcdgf0/qeADksVA7GSpsVRBOoLRfgf5 RCD85rO+dyi8G1x4x6cc/FTlrcWqkRS11O6FoEK8jW69Pl1WGJ0= X-Report-Abuse-To: spam@mx99.antispamcloud.com X-Filter-Fingerprint: IFrWXGses7OKB5S5G8/dJXhXyDRoOQM5J3kcUr0HrMvJUWjZ8+qhjyB23tbDuyLOYL8Ff78gYsez 4Rl08xudmXi4esCQ0R1MchVjt7wblGlvhFgW0MjUMRkF5sMCDfftTXNFDzN17hnrWeZYOJvLq0Ic WjZ+XcEjj/7Pkld0zkmvziDInX9WdMov2kn2yXjdwv61T+KDYyYtREgszdyFwv8IxCB3p/oCKvxr eyISh3JGb7OS5oVgiO+kDxZrVPLz3MmEGC2PrUKqLq5WmHK+Nw== X-Originating-IP: 88.159.208.100 X-Spampanel-Domain: topic.nl X-Spampanel-Username: 88.159.208.100 Authentication-Results: antispamcloud.com; auth=pass smtp.auth=88.159.208.100@topic.nl X-Spampanel-Outgoing-Class: ham X-Spampanel-Outgoing-Evidence: Combined (0.00) X-Recommended-Action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oops, "arch/arm/boot/dts/topic-dyplo.dtsi" should not have been in there. Will send a v2 patch to correct that. On 07-05-15 14:00, Mike Looijmans wrote: > When dma-coherent transfers are enabled, the mmap call must > not change the pg_prot flags in the vma struct. > > Split the arm_dma_mmap into a common and specific parts, > and add a "arm_coherent_dma_mmap" implementation that does > not alter the page protection flags. > > Tested on a topic-miami board (Zynq) using the ACP port > to transfer data between FPGA and CPU using the Dyplo > framework. Without this patch, byte-wise access to mmapped > coherent DMA memory was about 20x slower because of the > memory being marked as non-cacheable, and transfer speeds > would not exceed 240MB/s. > > After this patch, the mapped memory is cacheable and the > transfer speed is again 600MB/s (limited by the FPGA) when > the data is in the L2 cache, while data integrity is being > maintained. > > The patch has no effect on non-coherent DMA. > > Signed-off-by: Mike Looijmans > --- > arch/arm/boot/dts/topic-dyplo.dtsi | 1 + > arch/arm/mm/dma-mapping.c | 32 +++++++++++++++++++++++++------- > 2 files changed, 26 insertions(+), 7 deletions(-) Kind regards, Mike Looijmans System Expert TOPIC Embedded Products Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 Telefax: +31 (0) 499 33 69 70 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail