public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] leds: leds-gpio: Allow compile test if !GPIOLIB
Date: Thu, 07 May 2015 14:15:27 +0200	[thread overview]
Message-ID: <554B575F.7090101@samsung.com> (raw)
In-Reply-To: <1430986090-7243-4-git-send-email-geert@linux-m68k.org>

On 05/07/2015 10:08 AM, Geert Uytterhoeven wrote:
> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> Relax the dependency of LEDS_GPIO on GPIOLIB if COMPILE_TEST is
> enabled.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> This could be folded in "[PATCH 09/27] leds: Allow compile test of GPIO
> consumers if !GPIOLIB" once its dependencies are satisfied.
> ---
>   drivers/leds/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 8161cddc3f8d597a..1f6cb38335b52c3c 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -182,7 +182,7 @@ config LEDS_PCA9532_GPIO
>   config LEDS_GPIO
>   	tristate "LED Support for GPIO connected LEDs"
>   	depends on LEDS_CLASS
> -	depends on GPIOLIB
> +	depends on GPIOLIB || COMPILE_TEST
>   	help
>   	  This option enables support for the LEDs connected to GPIO
>   	  outputs. To be useful the particular board must have LEDs
>

Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>

-- 
Best Regards,
Jacek Anaszewski

  reply	other threads:[~2015-05-07 12:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07  8:08 [PATCH 0/3] leds: leds-gpio: Allow compile test if !GPIOLIB Geert Uytterhoeven
2015-05-07  8:08 ` [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface Geert Uytterhoeven
2015-05-08 17:43   ` Bryan Wu
2015-05-12  7:48     ` Geert Uytterhoeven
2015-05-12  7:47   ` Alexandre Courbot
2015-05-12 10:31   ` Linus Walleij
2015-05-12 17:48     ` Bryan Wu
2015-05-07  8:08 ` [PATCH 2/3] leds: leds-gpio: Add missing #include <linux/of.h> Geert Uytterhoeven
2015-05-07 12:15   ` Jacek Anaszewski
2015-05-12 17:49     ` Bryan Wu
2015-05-07  8:08 ` [PATCH 3/3] leds: leds-gpio: Allow compile test if !GPIOLIB Geert Uytterhoeven
2015-05-07 12:15   ` Jacek Anaszewski [this message]
2015-05-12 10:23   ` Linus Walleij
2015-05-12 17:53     ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554B575F.7090101@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=arnd@arndb.de \
    --cc=cooloney@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox