From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762AbbEGOhJ (ORCPT ); Thu, 7 May 2015 10:37:09 -0400 Received: from sender1.zohomail.com ([74.201.84.162]:28708 "EHLO sender1.zohomail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbbEGOhH (ORCPT ); Thu, 7 May 2015 10:37:07 -0400 Message-ID: <554B7884.90002@kerneldev.net> Date: Thu, 07 May 2015 09:36:52 -0500 From: Jaime Arrocha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Sudip Mukherjee CC: Jaime Arrocha , greg@kroah.com, abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: coding style identation error fix References: <20150506221341.GA31292@localhost.localdomain> <20150507053446.GA3631@sudip-PC> <554B6241.2010907@kerneldev.net> <20150507131658.GA15680@sudip-PC> In-Reply-To: <20150507131658.GA15680@sudip-PC> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMail: Ss SS_10 UW UB CHF_INT_SMD_EXT SGR4_1_16045_0 X-ZohoMail-Owner: <554B7884.90002@kerneldev.net>+zmo_0_ X-ZohoMail-Sender: 71.164.187.49 X-Zoho-Virus-Status: 2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2015 08:21 AM, Sudip Mukherjee wrote: > On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote: >> >> >> On 05/07/2015 12:34 AM, Sudip Mukherjee wrote: >>> On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote: >>>> Errors found by checkpatch.pl. >>>> ERROR: code indent should use tabs where possible >>>> /drivers/staging/comedi/drivers/das16m1.c:49 >>>> /drivers/staging/comedi/drivers/das16m1.c:50 >>>> >>>> Signed-off-by: Jaime Arrocha >>>> --- >>> you are sending this patch second time with different subject. >>> any reason for that? >>> >>> regards >>> sudip >>> >> >> Yes, the first one had the subject line too long and not clear. >> When I need to resend a patch like I did, should I add on the second >> one the reason behind resending and dismissing the first one? Thank >> you. > > first of all you should reply to the first patch stating that should not > be applied and that you have sent a second patch. And this one should > have had a v2 in the subject with the reason of v2 below the --- cutoff. > since you have already sent the second patch just reply to the fist > patch as of now. > And you have sent the patches to greg@kroah.com, it should have been > gregkh@linuxfoundation.org . always use get_maintainer.pl to see whom > to send patches. > > regards > sudip > > Thanks Sudip, I will dismiss this one too and do it correctly. I accidentally took Greg's email from the TODO file. This patch should not be applied. Thanks, jaime