From: York Sun <yorksun@freescale.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: <Julia.Lawall@lip6.fr>, <linux-i2c@vger.kernel.org>,
<wolfram@the-dreams.de>, <linux-kernel@vger.kernel.org>
Subject: Re: Why isn't IRQ shared for i2c-ocore
Date: Thu, 7 May 2015 07:46:29 -0700 [thread overview]
Message-ID: <554B7AC5.5040401@freescale.com> (raw)
In-Reply-To: <20150507070149.GB3400@x1>
On 05/07/2015 12:01 AM, Lee Jones wrote:
>> I have a follow up question regarding interrupt. I see many I2C bus drivers
>> request interrupt with flag = 0. Why not using IRQF_SHARED?
>
> Probably because that particular IRQ is only used by the I2C
> Controller. I'm not exactly sure that you're getting at? Why do you
> think it should be shared? You should only flag it as shared if it
> is.
I am working on a driver for multifunction card with open core I2C controller.
The interrupt is shared between I2C and other controller.
>
>> I understand the performance concern. If there is any other reason, I want to
>> know about it before I go too far on my driver.
>
> This sort of stuff is trivial to fix and shouldn't stand in the way
> of you writing and submitting v1 of your driver.
>
It is trivial to fix. I just want to know if there is any reason the interrupt
wasn't shared. Seems not.
York
next prev parent reply other threads:[~2015-05-07 16:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <55304D8E.8070204@freescale.com>
2015-04-17 15:47 ` Need some guidance on i2c-ocores driver York Sun
2015-04-20 6:42 ` Lee Jones
2015-04-20 16:24 ` York Sun
2015-04-20 18:16 ` Lee Jones
2015-04-20 18:31 ` York Sun
2015-04-21 7:35 ` Lee Jones
2015-05-06 21:41 ` Why isn't IRQ shared for i2c-ocore York Sun
2015-05-07 7:01 ` Lee Jones
2015-05-07 14:46 ` York Sun [this message]
2015-05-08 6:47 ` Geert Uytterhoeven
2015-05-08 6:57 ` Lee Jones
2015-05-08 7:07 ` Geert Uytterhoeven
2015-05-08 7:27 ` Lee Jones
2015-05-08 8:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B7AC5.5040401@freescale.com \
--to=yorksun@freescale.com \
--cc=Julia.Lawall@lip6.fr \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wolfram@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).