* problem building on ARM with XEN enabled
@ 2015-05-07 15:10 Michal Suchanek
2015-05-07 15:24 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Michal Suchanek @ 2015-05-07 15:10 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, xen-devel,
Linux Kernel Mailing List
Hello,
it appears the Linus master tree fails to build on ARM with XEN enabled.
Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend
provides the suspend function only for x86 this is not surprising.
I currently don't use XEN yet but building with XEN enabled was not a
problem in the past so this looks like a regression to me.
Thanks
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: problem building on ARM with XEN enabled
2015-05-07 15:10 problem building on ARM with XEN enabled Michal Suchanek
@ 2015-05-07 15:24 ` Boris Ostrovsky
2015-05-07 16:37 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Boris Ostrovsky @ 2015-05-07 15:24 UTC (permalink / raw)
To: Michal Suchanek, Konrad Rzeszutek Wilk, David Vrabel,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Stefano Stabellini,
xen-devel, Linux Kernel Mailing List
On 05/07/2015 11:10 AM, Michal Suchanek wrote:
> Hello,
>
> it appears the Linus master tree fails to build on ARM with XEN enabled.
>
> Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend
>
> provides the suspend function only for x86 this is not surprising.
>
> I currently don't use XEN yet but building with XEN enabled was not a
> problem in the past so this looks like a regression to me.
(+Stefano)
Does this fix it:
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 224081c..7d0f070 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { }
void xen_arch_post_suspend(int suspend_cancelled) { }
void xen_timer_resume(void) { }
void xen_arch_resume(void) { }
+void xen_arch_suspend(void) { }
/* In the hypervisor.S file. */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: problem building on ARM with XEN enabled
2015-05-07 15:24 ` Boris Ostrovsky
@ 2015-05-07 16:37 ` Stefano Stabellini
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2015-05-07 16:37 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: Michal Suchanek, Konrad Rzeszutek Wilk, David Vrabel,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Stefano Stabellini,
xen-devel, Linux Kernel Mailing List
On Thu, 7 May 2015, Boris Ostrovsky wrote:
> On 05/07/2015 11:10 AM, Michal Suchanek wrote:
> > Hello,
> >
> > it appears the Linus master tree fails to build on ARM with XEN enabled.
> >
> > Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend
> >
> > provides the suspend function only for x86 this is not surprising.
> >
> > I currently don't use XEN yet but building with XEN enabled was not a
> > problem in the past so this looks like a regression to me.
>
>
>
> (+Stefano)
>
> Does this fix it:
Yes, it does. Please go ahead and add it to xentip.
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 224081c..7d0f070 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { }
> void xen_arch_post_suspend(int suspend_cancelled) { }
> void xen_timer_resume(void) { }
> void xen_arch_resume(void) { }
> +void xen_arch_suspend(void) { }
>
>
> /* In the hypervisor.S file. */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-07 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 15:10 problem building on ARM with XEN enabled Michal Suchanek
2015-05-07 15:24 ` Boris Ostrovsky
2015-05-07 16:37 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox