[PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated

[PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated

[Gabriele Mazzotta]

Check whether the allocation of a new kfifo buffer failed or not before
setting the update_needed flag to false. This will make
iio_request_update_kfifo() try to allocate a new buffer the next time a
buffer update is requested.

Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
 drivers/iio/kfifo_buf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/kfifo_buf.c b/drivers/iio/kfifo_buf.c
index 847ca56..55c267b 100644
--- a/drivers/iio/kfifo_buf.c
+++ b/drivers/iio/kfifo_buf.c
@@ -38,7 +38,8 @@ static int iio_request_update_kfifo(struct iio_buffer *r)
 		kfifo_free(&buf->kf);
 		ret = __iio_allocate_kfifo(buf, buf->buffer.bytes_per_datum,
 				   buf->buffer.length);
-		buf->update_needed = false;
+		if (ret >= 0)
+			buf->update_needed = false;
 	} else {
 		kfifo_reset_out(&buf->kf);
 	}
-- 
2.1.4

Re: [PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated

[Jonathan Cameron]

On 02/05/15 13:31, Gabriele Mazzotta wrote:
> Check whether the allocation of a new kfifo buffer failed or not before
> setting the update_needed flag to false. This will make
> iio_request_update_kfifo() try to allocate a new buffer the next time a
> buffer update is requested.
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Applied to the fixes to greg branch of iio.git

The way things are going right now, I might actually get time to
push this out on Saturday.... Which is more than I expected this
morning.

J
> ---
>  drivers/iio/kfifo_buf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/kfifo_buf.c b/drivers/iio/kfifo_buf.c
> index 847ca56..55c267b 100644
> --- a/drivers/iio/kfifo_buf.c
> +++ b/drivers/iio/kfifo_buf.c
> @@ -38,7 +38,8 @@ static int iio_request_update_kfifo(struct iio_buffer *r)
>  		kfifo_free(&buf->kf);
>  		ret = __iio_allocate_kfifo(buf, buf->buffer.bytes_per_datum,
>  				   buf->buffer.length);
> -		buf->update_needed = false;
> +		if (ret >= 0)
> +			buf->update_needed = false;
>  	} else {
>  		kfifo_reset_out(&buf->kf);
>  	}
>