* [PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated
@ 2015-05-02 12:31 Gabriele Mazzotta
2015-05-07 22:38 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Gabriele Mazzotta @ 2015-05-02 12:31 UTC (permalink / raw)
To: jic23; +Cc: knaack.h, lars, pmeerw, linux-iio, linux-kernel,
Gabriele Mazzotta
Check whether the allocation of a new kfifo buffer failed or not before
setting the update_needed flag to false. This will make
iio_request_update_kfifo() try to allocate a new buffer the next time a
buffer update is requested.
Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
drivers/iio/kfifo_buf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/kfifo_buf.c b/drivers/iio/kfifo_buf.c
index 847ca56..55c267b 100644
--- a/drivers/iio/kfifo_buf.c
+++ b/drivers/iio/kfifo_buf.c
@@ -38,7 +38,8 @@ static int iio_request_update_kfifo(struct iio_buffer *r)
kfifo_free(&buf->kf);
ret = __iio_allocate_kfifo(buf, buf->buffer.bytes_per_datum,
buf->buffer.length);
- buf->update_needed = false;
+ if (ret >= 0)
+ buf->update_needed = false;
} else {
kfifo_reset_out(&buf->kf);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated
2015-05-02 12:31 [PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated Gabriele Mazzotta
@ 2015-05-07 22:38 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-05-07 22:38 UTC (permalink / raw)
To: Gabriele Mazzotta; +Cc: knaack.h, lars, pmeerw, linux-iio, linux-kernel
On 02/05/15 13:31, Gabriele Mazzotta wrote:
> Check whether the allocation of a new kfifo buffer failed or not before
> setting the update_needed flag to false. This will make
> iio_request_update_kfifo() try to allocate a new buffer the next time a
> buffer update is requested.
>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Applied to the fixes to greg branch of iio.git
The way things are going right now, I might actually get time to
push this out on Saturday.... Which is more than I expected this
morning.
J
> ---
> drivers/iio/kfifo_buf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/kfifo_buf.c b/drivers/iio/kfifo_buf.c
> index 847ca56..55c267b 100644
> --- a/drivers/iio/kfifo_buf.c
> +++ b/drivers/iio/kfifo_buf.c
> @@ -38,7 +38,8 @@ static int iio_request_update_kfifo(struct iio_buffer *r)
> kfifo_free(&buf->kf);
> ret = __iio_allocate_kfifo(buf, buf->buffer.bytes_per_datum,
> buf->buffer.length);
> - buf->update_needed = false;
> + if (ret >= 0)
> + buf->update_needed = false;
> } else {
> kfifo_reset_out(&buf->kf);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-07 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-02 12:31 [PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated Gabriele Mazzotta
2015-05-07 22:38 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox