From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751967AbbEGWt1 (ORCPT ); Thu, 7 May 2015 18:49:27 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:34826 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbbEGWt0 (ORCPT ); Thu, 7 May 2015 18:49:26 -0400 Message-ID: <554BEBF4.80307@google.com> Date: Thu, 07 May 2015 15:49:24 -0700 From: Badhri Jagan Sridharan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH v2] tracing: Adds handler name to irq_handler_entry References: <1430881587-13522-1-git-send-email-Badhri@google.com> <20150505231932.1500a4ad@grimm.local.home> <554BDCD1.8040508@google.com> <20150507175427.082f6ab7@gandalf.local.home> In-Reply-To: <20150507175427.082f6ab7@gandalf.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Steven :) I have made the changes that you mentioned and sent out an updated version of the patch. On 05/07/2015 02:54 PM, Steven Rostedt wrote: > On Thu, 07 May 2015 14:44:49 -0700 > Badhri Jagan Sridharan wrote: > >> Yes Steven.. It shouldn't be too difficult to find out the >> handler for a specific device. But, I am looking >> at some user space scripts that looks across different devices, >> to data-mine interrupt stats. Although, the interrupt >> numbers from the device tree change from one device to >> another, if its the same device driver, the handlers >> remain the same. So it gives me a good sense of >> similar interrupts that fire. >> >> If you think that its not to much of an overhead,I will send >> a follow up patch to correct the spacing error that you >> mentioned. > > OK. > >> >> And did you really add Thomas to CC ? > > Ug, utter fail :-p I wrote that from my laptop while upstairs (not in > my office) and did not have Thomas in my address book. Then my wife > came in and started talking to me, and when she left I hit send > (forgetting to add Thomas in the Cc). > > Added now! > > -- Steve > > >> >> Thanks, >> Badhri >> >> On 05/05/2015 08:19 PM, Steven Rostedt wrote: >>> [ Added Thomas to the Cc, as he maintains interrupts ] >>> >>> On Tue, 5 May 2015 20:06:27 -0700 >>> Badhri Jagan Sridharan wrote: >>> >>>> This patch includes the ISR function name to >>>> irq_handler_entry trace point. >>> >>> It states what this patch does, but not why it does it. >>> >>> How much more difficult to map the handler to the interrupt? >>> >>> Just asking, I'm not sure I needed this, and I use this tracepoint all >>> the time. But then again, I'm a bit of an tracing expert, and can add >>> function graph tracing to see what is happening too. I shouldn't always >>> be the judge on usefulness of added info here ;-) >>> >>>> >>>> Signed-off-by: Badhri Jagan Sridharan >>>> --- >>>> Changelog since v1: >>>> - fixed indentation >>>> >>>> include/trace/events/irq.h | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h >>>> index ff8f6c0..dd8918c 100644 >>>> --- a/include/trace/events/irq.h >>>> +++ b/include/trace/events/irq.h >>>> @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry, >>>> TP_STRUCT__entry( >>>> __field( int, irq ) >>>> __string( name, action->name ) >>>> + __field( void*, handler ) >>> >>> Nit, you need a space between 'void' and '*'. >>> >>> -- Steve >>> >>>> ), >>>> >>>> TP_fast_assign( >>>> __entry->irq = irq; >>>> __assign_str(name, action->name); >>>> + __entry->handler = action->handler; >>>> ), >>>> >>>> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name)) >>>> + TP_printk("irq=%d name=%s handler=%pf", >>>> + __entry->irq, __get_str(name), __entry->handler) >>>> ); >>>> >>>> /** >>> >