Re: [̈́PATCHv4 11/12] phy: helpers for USB ULPI PHY registering

[Kishon Vijay Abraham I <kishon@ti.com>]

On Friday 08 May 2015 12:25 AM, Felipe Balbi wrote:
> On Thu, May 07, 2015 at 09:19:31AM +0300, Heikki Krogerus wrote:
>> ULPI PHYs need to be bound to their controllers with a
>> lookup. This adds helpers that the ULPI drivers can use to
>> do both, the registration of the PHY and the lookup, at the
>> same time.
>>
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Acked-by: David Cohen <david.a.cohen@linux.intel.com>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>
> Kishon, need your Acked-by here and on the following patch. I think it's
> easier to merge it through my tree although there is not real harsh
> depedency, apparently.

Actually the next patch depends on USB_ULPI_BUS ;-)

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
>> ---
>>   drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>   create mode 100644 drivers/phy/ulpi_phy.h
>>
>> diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h
>> new file mode 100644
>> index 0000000..ac49fb6
>> --- /dev/null
>> +++ b/drivers/phy/ulpi_phy.h
>> @@ -0,0 +1,31 @@
>> +#include <linux/phy/phy.h>
>> +
>> +/**
>> + * Helper that registers PHY for a ULPI device and adds a lookup for binding it
>> + * and it's controller, which is always the parent.
>> + */
>> +static inline struct phy
>> +*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops)
>> +{
>> +	struct phy *phy;
>> +	int ret;
>> +
>> +	phy = phy_create(&ulpi->dev, NULL, ops);
>> +	if (IS_ERR(phy))
>> +		return phy;
>> +
>> +	ret = phy_create_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent));
>> +	if (ret) {
>> +		phy_destroy(phy);
>> +		return ERR_PTR(ret);
>> +	}
>> +
>> +	return phy;
>> +}
>> +
>> +/* Remove a PHY that was created with ulpi_phy_create() and it's lookup. */
>> +static inline void ulpi_phy_destroy(struct ulpi *ulpi, struct phy *phy)
>> +{
>> +	phy_remove_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent));
>> +	phy_destroy(phy);
>> +}
>> --
>> 2.1.4
>>
>