From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752348AbbEHFdA (ORCPT ); Fri, 8 May 2015 01:33:00 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39036 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbbEHFc5 (ORCPT ); Fri, 8 May 2015 01:32:57 -0400 Message-ID: <554C4A7F.9060602@ti.com> Date: Fri, 8 May 2015 11:02:47 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: , Heikki Krogerus CC: David Cohen , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , Paul Bolle , , Subject: Re: =?UTF-8?B?W82EUEFUQ0h2NCAxMS8xMl0gcGh5OiBoZWxwZXJzIGZvciBVU0I=?= =?UTF-8?B?IFVMUEkgUEhZIHJlZ2lzdGVyaW5n?= References: <1430979572-14768-1-git-send-email-heikki.krogerus@linux.intel.com> <1430979572-14768-12-git-send-email-heikki.krogerus@linux.intel.com> <20150507185538.GH29183@saruman.tx.rr.com> In-Reply-To: <20150507185538.GH29183@saruman.tx.rr.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 08 May 2015 12:25 AM, Felipe Balbi wrote: > On Thu, May 07, 2015 at 09:19:31AM +0300, Heikki Krogerus wrote: >> ULPI PHYs need to be bound to their controllers with a >> lookup. This adds helpers that the ULPI drivers can use to >> do both, the registration of the PHY and the lookup, at the >> same time. >> >> Signed-off-by: Heikki Krogerus >> Acked-by: David Cohen >> Cc: Kishon Vijay Abraham I > > Kishon, need your Acked-by here and on the following patch. I think it's > easier to merge it through my tree although there is not real harsh > depedency, apparently. Actually the next patch depends on USB_ULPI_BUS ;-) Acked-by: Kishon Vijay Abraham I > >> --- >> drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 drivers/phy/ulpi_phy.h >> >> diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h >> new file mode 100644 >> index 0000000..ac49fb6 >> --- /dev/null >> +++ b/drivers/phy/ulpi_phy.h >> @@ -0,0 +1,31 @@ >> +#include >> + >> +/** >> + * Helper that registers PHY for a ULPI device and adds a lookup for binding it >> + * and it's controller, which is always the parent. >> + */ >> +static inline struct phy >> +*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) >> +{ >> + struct phy *phy; >> + int ret; >> + >> + phy = phy_create(&ulpi->dev, NULL, ops); >> + if (IS_ERR(phy)) >> + return phy; >> + >> + ret = phy_create_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent)); >> + if (ret) { >> + phy_destroy(phy); >> + return ERR_PTR(ret); >> + } >> + >> + return phy; >> +} >> + >> +/* Remove a PHY that was created with ulpi_phy_create() and it's lookup. */ >> +static inline void ulpi_phy_destroy(struct ulpi *ulpi, struct phy *phy) >> +{ >> + phy_remove_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent)); >> + phy_destroy(phy); >> +} >> -- >> 2.1.4 >> >