From: Bert Vermeulen <bert@biot.com>
To: Frans Klaver <fransklaver@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards
Date: Fri, 08 May 2015 16:29:27 +0200 [thread overview]
Message-ID: <554CC847.6020004@biot.com> (raw)
In-Reply-To: <CAH6sp9OcFXcX6vgkPPJqCE-X1_fKPOBo0Ak2g=pWiWPZuCt5Yg@mail.gmail.com>
On 05/08/2015 12:14 PM, Frans Klaver wrote:
> On Thu, May 7, 2015 at 2:31 PM, Bert Vermeulen <bert@biot.com> wrote:
>> +
>> + info->chip.priv = info;
>> + info->mtd.priv = &info->chip;
>> + info->mtd.owner = THIS_MODULE;
>
> If you should respin, could you add
>
> info->mtd.dev.parent = &pdev->dev;
>
> This will have a symlink to the parent device show up in sysfs. Seems
> some people feel rather strongly about that.
Sure, will do. I'll wait for some comment from David Woodhouse or Brian
Norris first, in case there's something more substantial to fix as well.
--
Bert Vermeulen bert@biot.com email/xmpp
prev parent reply other threads:[~2015-05-08 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 12:31 [PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards Bert Vermeulen
2015-05-08 10:14 ` Frans Klaver
2015-05-08 14:29 ` Bert Vermeulen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CC847.6020004@biot.com \
--to=bert@biot.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fransklaver@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).