public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: tell the world boot_params is 16-byte aligned
Date: Fri, 08 May 2015 11:36:30 -0700	[thread overview]
Message-ID: <554D022E.6090503@zytor.com> (raw)
In-Reply-To: <20150508174054.GD3904@pd.tnic>

On 05/08/2015 10:40 AM, Borislav Petkov wrote:
> On Fri, May 08, 2015 at 09:26:49AM -0700, H. Peter Anvin wrote:
>> NAK.  This could break in the case of careless bootloaders...
> 
> Please elaborate. You mean, they'll go with the max alignment too and
> search boot_params there?
> 

A careless bootloader may not align this data structure to any
particular alignment.

Of course, for x86 it doesn't matter too much, as it just hurts performance.

	-hpa


      reply	other threads:[~2015-05-08 18:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 13:42 [PATCH] x86: tell the world boot_params is 16-byte aligned Rasmus Villemoes
2015-05-08 14:24 ` Borislav Petkov
2015-05-08 16:23   ` Rasmus Villemoes
2015-05-08 16:26     ` H. Peter Anvin
2015-05-08 17:40       ` Borislav Petkov
2015-05-08 18:36         ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554D022E.6090503@zytor.com \
    --to=hpa@zytor.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox