From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@fb.com>, <linux-kernel@vger.kernel.org>
Cc: <jmoyer@redhat.com>, <hch@lst.de>, <neilb@suse.de>
Subject: Re: [PATCH 1/6 v2] blk: clean up plug
Date: Fri, 8 May 2015 14:18:33 -0600 [thread overview]
Message-ID: <554D1A19.8010407@fb.com> (raw)
In-Reply-To: <726972cd3a12680e1b2ac819f989c0f65c77c1b4.1431106907.git.shli@fb.com>
On 05/08/2015 11:51 AM, Shaohua Li wrote:
> Current code looks like inner plug gets flushed with a
> blk_finish_plug(). Actually it's a nop. All requests/callbacks are added
> to current->plug, while only outmost plug is assigned to current->plug.
> So inner plug always has empty request/callback list, which makes
> blk_flush_plug_list() a nop. This tries to make the code more clear.
Applied 1-6, thanks Shaohua!
--
Jens Axboe
prev parent reply other threads:[~2015-05-08 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 17:51 [PATCH 1/6 v2] blk: clean up plug Shaohua Li
2015-05-08 17:51 ` [PATCH 2/6 v2] sched: always use blk_schedule_flush_plug in io_schedule_out Shaohua Li
2015-05-08 17:51 ` [PATCH 3/6 v2] blk-mq: fix plugging in blk_sq_make_request Shaohua Li
2015-05-08 17:51 ` [PATCH 4/6 v2] blk-mq: avoid re-initialize request which is failed in direct dispatch Shaohua Li
2015-05-08 17:51 ` [PATCH 5/6 v2] blk-mq: do limited block plug for multiple queue case Shaohua Li
2015-05-08 17:51 ` [PATCH 6/6 v2] blk-mq: make plug work for mutiple disks and queues Shaohua Li
2015-05-08 20:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554D1A19.8010407@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox