From: Richard Weinberger <richard@nod.at>
To: Joe Perches <joe@perches.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vsprintf: Add support for userspace strings
Date: Sun, 10 May 2015 22:22:30 +0200 [thread overview]
Message-ID: <554FBE06.1010700@nod.at> (raw)
In-Reply-To: <1431288982.29257.31.camel@perches.com>
Am 10.05.2015 um 22:16 schrieb Joe Perches:
> On Sun, 2015-05-10 at 22:11 +0200, Richard Weinberger wrote:
>> Am 10.05.2015 um 22:09 schrieb Joe Perches:
>>> On Sun, 2015-05-10 at 21:42 +0200, Richard Weinberger wrote:
>>>> Add %pL format string to print userspace strings.
>>>> It works like %s but does copy_from_user() instead
>>>> of a memcpy().
>>>
>>> I think this would be much simpler in a new
>>> function rather than complicating string()
>>
>> -ENOPATCH.
>
> It's your patch, I'm just commenting on it.
Yeah, if you read string() you'll notice that it adds only
very few lines. Duplicating string() is not a good idea.
%pL is not a completely new feature it just covers a %s corner
case.
> I'm not sure there's much value in it.
Maybe because you're not in the kernel-debugging-business? ;-)
> Can it can add security holes if used with %pV?
If abused every kernel function can be used to add security holes.
As I wrote the goal of %pL is for debugging.
Thanks,
//richard
next prev parent reply other threads:[~2015-05-10 20:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 19:42 vsprintf: Add support for userspace strings Richard Weinberger
2015-05-10 19:42 ` [PATCH 1/2] Fix printk() on ERR_PTR() Richard Weinberger
2015-05-11 23:20 ` Andrew Morton
2015-05-12 7:23 ` Richard Weinberger
2015-05-10 19:42 ` [PATCH 2/2] vsprintf: Add support for userspace strings Richard Weinberger
2015-05-10 20:09 ` Joe Perches
2015-05-10 20:11 ` Richard Weinberger
2015-05-10 20:16 ` Joe Perches
2015-05-10 20:22 ` Richard Weinberger [this message]
2015-05-11 23:23 ` Andrew Morton
2015-05-12 7:31 ` Richard Weinberger
2015-05-11 0:24 ` Masami Hiramatsu
2015-05-11 8:59 ` Richard Weinberger
2015-05-11 10:57 ` Richard Weinberger
2015-05-11 20:42 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554FBE06.1010700@nod.at \
--to=richard@nod.at \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox