From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75A78B640 for ; Tue, 23 Sep 2025 01:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758589371; cv=none; b=sual88bFBmnkJAv5QTp6FsEizXn1k/5j4oPMl8nR1+kmN0yogf3zKlVOjM9fTEyx3FpEyRNh9uoFPqa0eDSrxVC331zZoLNqTWQtfxnNxfy4T6Nrk45B6FhZEFMD5yyOWSD3Ln9xKfJnIyb5isH/bTG8Mbf2/ZA4qTDLx6Q0Rx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758589371; c=relaxed/simple; bh=/wREhakS9idFjMBFdgBH/9xcwM7cylJ4oNqe9PN39SA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gv9zFaBsIDKa4Pdh0DoQ6K+5npE5v82zr2kFBth+YpzTUzCDBOYDhEoNIbAtV20vgAeDYXsYkuS2/UHxQv8c0D4mAR3P+5bOGCIBH/DwckZ86gTOzn8logEdX8Xk3pMLP7uo3txMTh+SJKyjMuv296XIQW4zy6NyqdoBTGe+TW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K6mgVDc3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K6mgVDc3" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58MGvcuD028468 for ; Tue, 23 Sep 2025 01:02:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jO1Hn2IrqcZtq+1Jj6/zX+hsmwYf9XJSmw5T569R8N0=; b=K6mgVDc3DjcU/uHP 6mQIORxFavj9i6bOju/Mzbgwqv+69i6VDoRmGyevoK6uL9zeZwc/FhEDtQfMryKe Lt16E+a9MBDInSgAGjGgID2c03l+ALXkEvsLuCkZzhWznsc6xg+8X11hG833Plxq ghkE5JZ8cpE3gtXTsftZHtGjMsPwB0YnS3wYPGBbmKo1s8U+j2ZnmrV/ZDFbScmW hhPin1o9sD+Dpjg+YCKl+AiZcVWEEt/VKIcsycnD7H2K1QoeV8Ec37Zo2q0XgdI3 6j4Y4jKWirvKp7bDFrQSKe648K3PPIwLyr+JMgzQ2jUn4hwnk2USDCH5vhdsKQwk rRaFIw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 499mn7envc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 23 Sep 2025 01:02:49 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-32eb18b5659so5235698a91.2 for ; Mon, 22 Sep 2025 18:02:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758589368; x=1759194168; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jO1Hn2IrqcZtq+1Jj6/zX+hsmwYf9XJSmw5T569R8N0=; b=ATXwaRvWyXfyOatnrqdPCjZEyp6z9yiDbA5y/PbwSiXJUYiVQPG6bNCQZMs7ikJnI9 zmGj6i+q+waZJXHD4mav99MDXXpy1hREnBEMXisYL3dVPd3cOQ5oaxGo3168glyiQnBG Kx8tbLwN42jrOnFYdrk0LM9M5a10qys5eoMtIyItoMSK/4cZN0oLYe73hL/sGtsiHhjf VzpIAJ6DajOJzZUWesBKu0uyrx09lx9Xp8+W8n1q5lBKdjI0m3dDGtnlnzz3oaczwEHJ asgWpcsx2kwR/mrpenj5mkUL6L1FBVTCTnfXoi/lyYkVwpUKu509QboiW7tqb5QF7c+a Sw9w== X-Forwarded-Encrypted: i=1; AJvYcCUD2MCik2PM73WZleP4ApYKfYhluOeyBhrb5jdOlychts6lcpGWcy/FbNWeEyBnk3eWiLwa0NOO0NVh38U=@vger.kernel.org X-Gm-Message-State: AOJu0YysS9XJRimSP0MoTZ/JoUgNdY+8ZrH5vHL5WczP/BbRkl3uUWyg A5mO7TlrJVAG7IOtASNSMJg1Eibz7DSBOrG+DNy/C0xZPwjMHrh1WduVH+BAEjs/RZU3dkMKkIF VOXnrVc+CVoVhi+9/BlAcLAJmMz8ka22Q1obnWJX/e+L2cu1AYI5KH1PAlK7e4OS8bM0= X-Gm-Gg: ASbGncstdYg5weBilDEa3yZyxRMKsLWNFd69rG6rkXC6OBiuat+jgW6m5vl8p+1XYfO wA6haZHVzJxUXer8zY/bMjPrxVbgsn2HuvN9UgtZHJuwZYPwVg4/uoLAwiAAdvOH/BtJPzKl7FP DEs5RdiJHEUyUIvOQOfjPMWDW8R3wvOGMFXa1Y5ONdFzR3QrjDSsIpQuBURx/onV3uOflnF9eTo VIDFoQlzmQOU+D6gdUm9cRslEAnpT1wa10Zm2ntMthKi9sGIdmR6JnXYexLmpqjBv/7oXhwhzBG vSLXRZjDv+tr14sqbvLb27m2qfCyYEo2piLY6MZCuZiUO9L64EWWn1FFfDukcb3iD3VlCGEL/L8 ujb0bD+k1PumeeCZ/B65I9VAuMAyt5cA= X-Received: by 2002:a17:90b:4cc6:b0:32e:a60d:93e2 with SMTP id 98e67ed59e1d1-332a950f0e8mr897277a91.11.1758589368167; Mon, 22 Sep 2025 18:02:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlSOwvGDc4ZNG/GFMoIc8OAWT84NHpnX1KIVGYK3J2uWpSVJtvuEHH3EjH2XRE1NcabBx9jA== X-Received: by 2002:a17:90b:4cc6:b0:32e:a60d:93e2 with SMTP id 98e67ed59e1d1-332a950f0e8mr897240a91.11.1758589367782; Mon, 22 Sep 2025 18:02:47 -0700 (PDT) Received: from [192.168.1.239] (syn-075-080-180-230.res.spectrum.com. [75.80.180.230]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77cfbb7b9e0sm13852534b3a.6.2025.09.22.18.02.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Sep 2025 18:02:47 -0700 (PDT) Message-ID: <554cd2ce-a617-9387-7379-a3c2b9de843c@oss.qualcomm.com> Date: Mon, 22 Sep 2025 18:02:45 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 3/9] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible Content-Language: en-US To: Rob Herring Cc: krzk+dt@kernel.org, conor+dt@kernel.org, kishon@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org References: <20250920032108.242643-1-wesley.cheng@oss.qualcomm.com> <20250920032108.242643-4-wesley.cheng@oss.qualcomm.com> <20250922201449.GA1235521-robh@kernel.org> From: Wesley Cheng In-Reply-To: <20250922201449.GA1235521-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTIwMDAzMyBTYWx0ZWRfXwAxEoSRxItg+ R2OUqRv1C45h40B3EqOnZIqhqVMW0vx/1hKHK5euLuJDNyIhrj4OIht3LdVh7367o8B87FbQQ+B PS5r1S7ATVgOvGEcY5LL/lt81/0zSA81FHm0Bs7qWoKZ0KjlRoztSvLDBnSXVrnkXrnIKhBApuU ijuDAJH+Qc7ZLGxeXOFO5qD/ea5diFTsNXt2e19uho/Eu31yYgbrbbhGQ9eFazzoFPb9YftkMyZ abLgLrrQugqDj9soaZFXPAzpdeOHAIb/t0Gm+KPiAFWufJtJAHmR/qUcI+LtKGMYJqTaxSzM98O WD+mfGb9As3k1+rZzRethFhg9lf3MEHCiD+nrNfUZAgUPcw+PfsSeFV2+2O7oOQ7QnaZ39B7MFY WnVADJOa X-Proofpoint-GUID: daRvhOy5aZLB59th7flc4_LYS1s-y_IJ X-Proofpoint-ORIG-GUID: daRvhOy5aZLB59th7flc4_LYS1s-y_IJ X-Authority-Analysis: v=2.4 cv=EZrIQOmC c=1 sm=1 tr=0 ts=68d1f1b9 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=agQD+r7xwyS+FYqxhQjztw==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=O8CPnEiu1cSv67x46V8A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-22_05,2025-09-22_05,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509200033 On 9/22/2025 1:14 PM, Rob Herring wrote: > On Fri, Sep 19, 2025 at 08:21:02PM -0700, Wesley Cheng wrote: >> Add the Glymur compatible to the M31 eUSB2 PHY, and use the SM8750 as >> the fallback. >> >> Signed-off-by: Wesley Cheng >> --- >> .../devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml >> index c84c62d0e8cb..b96b1ee80257 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml >> @@ -15,9 +15,12 @@ description: >> >> properties: >> compatible: >> - items: >> - - enum: >> - - qcom,sm8750-m31-eusb2-phy >> + oneOf: >> + - items: >> + - enum: >> + - qcom,glymur-m31-eusb2-phy >> + - const: qcom,sm8750-m31-eusb2-phy >> + - const: qcom,sm8750-m31-eusb2-phy >> >> reg: >> maxItems: 1 >> @@ -53,8 +56,6 @@ required: >> - compatible >> - reg >> - "#phy-cells" >> - - clocks >> - - clock-names > > How is it compatible if clocks aren't required now? And clocks are > suddenly no longer required on sm8750? > Hi Rob, It depends on the clock subsystem. On SM8750, we still need the clock entry, because we need to control the output of our CXO/reference clock to our HS PHY. However, on chipsets like Glymur, some HS PHYs in our USB subsystem doesn't have this refclk output control. Thanks Wesley Cheng >> - resets >> - vdd-supply >> - vdda12-supply