From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbbEKQ7T (ORCPT ); Mon, 11 May 2015 12:59:19 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:38995 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbbEKQ7R (ORCPT ); Mon, 11 May 2015 12:59:17 -0400 Message-ID: <5550DFD2.6090805@fb.com> Date: Mon, 11 May 2015 12:58:58 -0400 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Christoph Hellwig , Bart Van Assche CC: Shaohua Li , linux-kernel , Stefan Haberland Subject: Re: [PATCH] block: Refine blk_abort_request() documentation References: <55509060.4010601@sandisk.com> <20150511114456.GA5097@lst.de> In-Reply-To: <20150511114456.GA5097@lst.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-05-11_03:2015-05-09,2015-05-11,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2015 07:44 AM, Christoph Hellwig wrote: > On Mon, May 11, 2015 at 01:20:00PM +0200, Bart Van Assche wrote: >> Document when it is safe to call this function for blk-mq queues. > > Maybe we should move the queue_lock acquisition into blk_abort_request > for the !blk-mq case? libata and libsas already take it just around the > call, an the usage in the dasd driver looks like it only needs > the queue_lock for the blk_abort_request call as well. I think so. -- Jens Axboe