From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752326AbbEKRNP (ORCPT ); Mon, 11 May 2015 13:13:15 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:33800 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbbEKRNL (ORCPT ); Mon, 11 May 2015 13:13:11 -0400 Message-ID: <5550E323.1080800@linaro.org> Date: Mon, 11 May 2015 19:13:07 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Paul Gortmaker , linux-kernel@vger.kernel.org CC: "Rafael J. Wysocki" , Michal Simek , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/7] drivers/cpuidle: Convert non-modular drivers to use builtin_driver_register References: <1431287385-1526-1-git-send-email-paul.gortmaker@windriver.com> <1431287385-1526-4-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1431287385-1526-4-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2015 09:49 PM, Paul Gortmaker wrote: > All these drivers are configured with Kconfig options that are > declared as bool. Hence it is not possible for the code > to be built as modular. However the code is currently using the > module_platform_driver() macro for driver registration. > > While this currently works, we really don't want to be including > the module.h header in non-modular code, which we'll be forced > to do, pending some upcoming code relocation from init.h into > module.h. So we fix it now by using the non-modular equivalent. > > Cc: "Rafael J. Wysocki" > Cc: Daniel Lezcano > Cc: Michal Simek > Cc: linux-pm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker Sounds reasonable. -- Daniel > --- > drivers/cpuidle/cpuidle-at91.c | 3 +-- > drivers/cpuidle/cpuidle-calxeda.c | 3 +-- > drivers/cpuidle/cpuidle-zynq.c | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-at91.c b/drivers/cpuidle/cpuidle-at91.c > index f2446c78d87c..9c5853b6ca4a 100644 > --- a/drivers/cpuidle/cpuidle-at91.c > +++ b/drivers/cpuidle/cpuidle-at91.c > @@ -62,5 +62,4 @@ static struct platform_driver at91_cpuidle_driver = { > }, > .probe = at91_cpuidle_probe, > }; > - > -module_platform_driver(at91_cpuidle_driver); > +builtin_platform_driver(at91_cpuidle_driver); > diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c > index 9445e6cc02be..c13feec89ea1 100644 > --- a/drivers/cpuidle/cpuidle-calxeda.c > +++ b/drivers/cpuidle/cpuidle-calxeda.c > @@ -75,5 +75,4 @@ static struct platform_driver calxeda_cpuidle_plat_driver = { > }, > .probe = calxeda_cpuidle_probe, > }; > - > -module_platform_driver(calxeda_cpuidle_plat_driver); > +builtin_platform_driver(calxeda_cpuidle_plat_driver); > diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c > index 543292b1d38e..6f4257fc56e5 100644 > --- a/drivers/cpuidle/cpuidle-zynq.c > +++ b/drivers/cpuidle/cpuidle-zynq.c > @@ -73,5 +73,4 @@ static struct platform_driver zynq_cpuidle_driver = { > }, > .probe = zynq_cpuidle_probe, > }; > - > -module_platform_driver(zynq_cpuidle_driver); > +builtin_platform_driver(zynq_cpuidle_driver); > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog