From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754884AbbEKSYH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 May 2015 14:24:07 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:56928 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753132AbbEKSYE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 May 2015 14:24:04 -0400
Message-ID: <5550F3BD.3000904@infradead.org>
Date: Mon, 11 May 2015 11:23:57 -0700
From: Randy Dunlap <rdunlap@infradead.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Josh Triplett <josh@joshtriplett.org>, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Michal Hocko <mhocko@suse.cz>,
        Vladimir Davydov <vdavydov@parallels.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Bertrand Jacquin <beber@meleeweb.net>,
        "Luis R. Rodriguez" <mcgrof@suse.com>,
        Iulia Manda <iulia.manda21@gmail.com>,
        Pranith Kumar <bobby.prani@gmail.com>,
        Clark Williams <clark.williams@gmail.com>,
        Mel Gorman <mgorman@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/Kconfig: Fix break in middle of EXPERT menu
References: <20150511181327.GA1884@jtriplet-mobl1>
In-Reply-To: <20150511181327.GA1884@jtriplet-mobl1>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/11/15 11:13, Josh Triplett wrote:
> Commit e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y &&
> !CONFIG_TRACING kernels, make it more configurable") made BPF_SYSCALL no
> longer hidden with !EXPERT, but left it in the middle of the EXPERT
> menu.  menuconfig stops putting config items under a submenu once it
> encounters an item that doesn't depend on the menu's config item, so
> this caused the remainder of the EXPERT menu to spill out into the
> containing menu around it.  Fix by moving BPF_SYSCALL before the EXPERT
> menu, next to BPF.
> 
> Fixes: e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable")
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> 
> Ingo, do you want to take this through -tip?  Or should this go through some
> other tree?
> 
> I'm also thinking about splitting the entire EXPERT menu into a separate
> Kconfig.expert and including it from init/Kconfig, to make it clear that
> everything in that menu should only be visible if EXPERT.  Right now, the long
> EXPERT menu blends into the longer init/Kconfig, and issues like this happen
> every few kernel releases.

Please do make it more difficult to break this.  I have also fixed this
a few times IIRC.


-- 
~Randy