From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932258AbbEKVFa (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 May 2015 17:05:30 -0400
Received: from terminus.zytor.com ([198.137.202.10]:39698 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751408AbbEKVF2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 May 2015 17:05:28 -0400
Message-ID: <55511989.2010407@zytor.com>
Date: Mon, 11 May 2015 14:05:13 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Richard Weinberger <richard@nod.at>,
        Linux-Arch <linux-arch@vger.kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: VERIFY_READ/WRITE in uaccess.h?
References: <554F288C.3000300@nod.at>
In-Reply-To: <554F288C.3000300@nod.at>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/10/2015 02:44 AM, Richard Weinberger wrote:
> Hi!
> 
> While cleaning up UML's uaccess code I've noticed that not a single architecture
> is using VERIFY_READ/WRITE in access_ok().
> One exception is UML, it uses the access type in one check which is in vain anyways.
> Also asm-generic/uaccess.h drops the type parameter silently.
> 
> Why do we still carry it around?
> 
> Is it because we want it for some future architecture which can benefit
> from it or just because nobody cared enough to do a tree-wide cleanup?
> I fear it is the latter... ;)
> 

Or, perhaps, nobody noticed?

	-hpa