From: Mike Christie <michaelc@cs.wisc.edu>
To: Chris Leech <cleech@redhat.com>,
linux-kernel@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad@kernel.org>
Cc: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] iscsi_ibft: filter null v4-mapped v6 addresses
Date: Mon, 11 May 2015 19:07:54 -0500 [thread overview]
Message-ID: <5551445A.2050103@cs.wisc.edu> (raw)
In-Reply-To: <1431062071-7074-1-git-send-email-cleech@redhat.com>
On 05/08/2015 12:14 AM, Chris Leech wrote:
> I've had reports of UEFI platforms failing iSCSI boot in various
> configurations, that ended up being caused by network initialization
> scripts getting tripped up by unexpected null addresses (0.0.0.0) being
> reported for gateways, dhcp servers, and dns servers.
>
> The tianocore EDK2 iSCSI driver generates an iBFT table that always uses
> IPv4-mapped IPv6 addresses for the NIC structure fields. This results
> in values that are "not present or not specified" being reported as
> ::ffff:0.0.0.0 rather than all zeros as specified.
>
> The iscsi_ibft module filters unspecified fields from the iBFT from
> sysfs, preventing userspace from using invalid values and making it easy
> to check for the presence of a value. This currently fails in regard to
> these mapped null addresses.
>
> In order to remain consistent with how the iBFT information is exposed,
> we should accommodate the behavior of the tianocore iSCSI driver as it's
> already in the wild in a large number of servers.
>
> Tested under qemu using an OVMF build of tianocore EDK2.
>
> Signed-off-by: Chris Leech <cleech@redhat.com>
Looks ok to me.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2015-05-12 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 5:14 [PATCH] iscsi_ibft: filter null v4-mapped v6 addresses Chris Leech
2015-05-12 0:07 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5551445A.2050103@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=cleech@redhat.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox