From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932156AbbELGGq (ORCPT ); Tue, 12 May 2015 02:06:46 -0400 Received: from mail-bl2on0063.outbound.protection.outlook.com ([65.55.169.63]:35360 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932120AbbELGGn (ORCPT ); Tue, 12 May 2015 02:06:43 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; lip6.fr; dkim=none (message not signed) header.d=none; Message-ID: <55519867.2090205@xilinx.com> Date: Tue, 12 May 2015 08:06:31 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Julia Lawall , Michal Simek CC: , =?windows-1252?Q?S=F6ren_Brinkmann?= , , Fabian Frederick , , "David S. Miller" , =?windows-1252?Q?Manuel_Sch=F6lling?= , Markus Elfring , Subbaraya Sundeep Bhatta , Subject: Re: [PATCH] net: ll_temac: Fix DMA map size bug References: In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-7.5.0.1018-21536.005 X-TM-AS-User-Approved-Sender: Yes;Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD016;1:dy5jrrv1lJ3Bb4Sfr7rUIfOE4uxyoq2A2xmIA1UQRp52X7DxxBAmNfB+Ub2nI4tCPLMkpzaglJ+PaXXVrpuViaq7EcpemCzF3H47mUyAaE3d1PGrErapg1TY0YndaSi5fv5H6sYZ2L5wbcqjDuMUZGSz2cIypkdEyubtYM8w5K8J7rE2UKnqU1KtUoPh/Ft/MA2IoVNq0TOzgo4ekzNW+fGyJdFAtTf2ou+KGIFqFIVjbIZmqlJ2Fh9F3rJ5FBag74mXbdv75f4gw9swi+TphMzc+EluQXjs6fXfZTOK7z8= X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(438002)(51704005)(479174004)(189002)(24454002)(377454003)(164054003)(199003)(87936001)(86362001)(63266004)(189998001)(36756003)(36386004)(54356999)(87266999)(77156002)(77096005)(62966003)(5001960100002)(50466002)(76176999)(46102003)(64126003)(2950100001)(106466001)(92566002)(117636001)(59896002)(19580395003)(19580405001)(5001920100001)(6806004)(5001770100001)(83506001)(81156007)(4001350100001)(65956001)(47776003)(65806001)(99136001)(65816999)(50986999)(23746002)(7059030)(107986001)(62816006)(4001450100001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB001;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:ovrnspm;MX:1;A:1;PTR:unknown-60-83.xilinx.com;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1BFFO11HUB001;2:rpBfglbYJpywm536wMztH3t0My9EQW4lFAcX?= =?Windows-1252?Q?pt3wxq6pxZy+9L4fuxaS5GY9BTAc;2:Q+8encZH+sWOUKWul+JysbPQQ?= =?Windows-1252?Q?F5znLuW4r8c190u8O6lGV5Q1BahFAsHh+Audhj4lnPD5cYvYSHUtgi+z?= =?Windows-1252?Q?JOC6ap/PBEbgMYn9+Ms9DXaOfPVJjDNi2ADsA8BREES9h94pDFNwnXSp?= =?Windows-1252?Q?Vn0fsoc89KyXH18MRbL4nuxt9wCP/UdjXrk1zAhAl1gTV7wcsv18fOEW?= =?Windows-1252?Q?RwJiJdw38WIIS1rpk9e+It7o91G6kqHV6EzPpjnEP0=3D;6:EWHcp9GI?= =?Windows-1252?Q?sFf8vYRhJ2RFA/F3Jw2aJLVaxwEDbleSk8rf2jv7WqXOXkGWK3An3mbu?= =?Windows-1252?Q?ARzjrYMMM4G0attMhstURm14R+ncUeyjfGJp02rVJFPwLaLWei2ebyLD?= =?Windows-1252?Q?mcY8J+go1lMqKA6/2SbO4AUQuWF1+/2KvsdRrjtz7gKrDZMZvb42z+Jc?= =?Windows-1252?Q?gzbBZYZXdeFfu5CNSHQIYrXPHT692Ku604x7up0sfdUzCMNsRRsHNR1f?= =?Windows-1252?Q?hTPvsqe7k2W5LANCcCCcai5BYu4zkY0RIG4583vAWwWGVoEZlxCWBYMU?= =?Windows-1252?Q?4369HgL8G1wfEOwQnVcjHO4YcQ0j9f6+aIWZCfAvURxwptwZ4jK/ODFD?= =?Windows-1252?Q?U7rIxhj9MUc4fDTPc44FKsV7yIzjKeHerJhwmc4QmlryhuSncqbZQvTO?= =?Windows-1252?Q?jXsfokiO3xczTgEvfxR3AQLmlGktHSGUBeHAeyW+croSEezbbycIZ+A6?= =?Windows-1252?Q?7AvgQbAtj9KknbIsqgdCfVdjoW2tI0mEyeXACzVDI6CyQQw6A82KaadQ?= =?Windows-1252?Q?;3:sLgKg8UkBO/afWb22zgAy3+vVc0AKjyjkCK/9uG7cm0uDiZdg6Cwn?= =?Windows-1252?Q?hUq1rdGtlkNKeWXm/d4+wt3R2g+KPT6lbgkKxd0WQY7T8kMeE8qAhY04?= =?Windows-1252?Q?9yqU7j3J501RoPWoH6Ry8KzQXUJfhf/xfcNPIoNR=0D=0A=0D=0A=0D?= =?Windows-1252?Q?=0A=0D=0A1k2r4TIY9UM3gyVdytzUT1mYej2vdZHPkBMBVMkZfe7FNrb?= =?Windows-1252?Q?9+4dfDhE6R++iuyz51W0VdOp5CcT3QuyrsZ80DAdx27j6Yl4OSW/ClOw?= =?Windows-1252?Q?37cbRXgRxeo3nM1bQkoDnqyNqOioYAFkx/3ANIi/ffFldmg=3D;9:9rP?= =?Windows-1252?Q?+1SaMV90iMdXUenlYE+ZFjOsKTd6/Xug0reIW38I+6qbU51EQ7b6TrZI?= =?Windows-1252?Q?KeL+tzQW26poml/vjyxb1vUseQthUJC0AisQv/fY//kWWqWxm0Y6gxtH?= =?Windows-1252?Q?rCeUVpgLMcezBc3peY8fshJn7V/gjMGNjv+esX30Vu3Gpa/EPxs4XDVI?= =?Windows-1252?Q?xY+bGNB702/jAWDAnZ92jmo46ybNMuL0RUcApfIAnEqP1hiNYNMwK0yu?= =?Windows-1252?Q?0XJW1dNfOcsfSzJLvM1zw9dkOCv5clcJ8itTHPnJ40WHOvriAX/NRBbh?= =?Windows-1252?Q?vCAYLAdDniZvqFiTGIqAK5UShd79MZ7c7ZZ8xyrB505dFR1gP+jkIhuc?= =?Windows-1252?Q?4IvTXYnwP2meQTgy7/uo0z1oYpmzrLBPN7FN8gKAvCZGPd3W1rBSMH99?= =?Windows-1252?Q?DdskXSK6GMcPhDdsCG32O/juMhJG6KOfSaxYcHJUfl+faquGckQPjgEY?= =?Windows-1252?Q?azeL7OSSvl0Qwbd5rjt093QcrAYtlfqO8KDHw6iTFGNNIf6QKsvfPjSC?= =?Windows-1252?Q?192VTkZQwp5xNxcIyCizEssCr8fqw9EoQcpJ/aPEvGChxnKCx4R6AhnY?= =?Windows-1252?Q?co/OR0Pe/EV79/dm0LV4kn4v1ryQUhhTr9XPa4WhPrdWHrV0FHpW1+xF?= =?Windows-1252?Q?wMVWx3DXxMaIeVI/Ilbkdmi8QgqRNb4JNLjJ4EssGXwShhXrGTWZ6qA1?= =?Windows-1252?Q?kG3gJz5jhcoglaPFFF8kbX6wdxgZYH/NT+n7TYCiPZABTgKKDUzxrZb4?= =?Windows-1252?Q?4n3d53qzs+IDaarQq8RJBaayZE2AuEw4YtVqFTZA3FzquVz2gOjyP3Gm?= =?Windows-1252?Q?tGvl9vAamZoLo9TRJUMwJTkOue8jMC8WrcxcVksIBVa=0D=0Ae/=0D?= =?Windows-1252?Q?=0AiE=0D=0A64Q/l7jbb/Shun0JugeKPhK/gtRVYESFmqYBFI9kD4IQ9?= =?Windows-1252?Q?PqKJNX2whXZHsUTSJNufewIe+FdkbD1NZiOD0fLjfzctObErsac6NJFt?= =?Windows-1252?Q?IUh183sm++vfxej1ExmMNCcANLATIvRSvqYAhiKobZL2Rm+GrYZ2I8JK?= =?Windows-1252?Q?55tJG4ZQxpSRlJBqqJL6oAzVRHgfnImJ4Ypb+ftowe17NDEvnHX/9Yl2?= =?Windows-1252?Q?k0vAnSApQwfaOzUcUY6aItT7dVIeOWeKPoRTC49jnv41A4FKMmo4Zuif?= =?Windows-1252?Q?b0j+QVf1C8aLPXi8NlwBWfxKw+s8O/r4cQIV0fCraZmrfAGb1KsK2jTB?= =?Windows-1252?Q?joWgBn09VO/vT9l2xvNwf+s4Xb27yIgJ/LO1GfgJxX/5u0Iy0EYx/4F1?= =?Windows-1252?Q?5sXWJx+sNkQFWTs37p8iJoicugC/VRIHpbZ/jTLn4zm0rektifhrNm18?= =?Windows-1252?Q?wm0P+cnfOq0I7TW3IRbIzUYcb8aFkV975UQhBMJuof5bgO1WDOueTL7Z?= =?Windows-1252?Q?NHctUUwMb3gE0KhNYts3bm64kBfHoPudBpl9Xwg=3D=3D;3:UW5xV0+i?= =?Windows-1252?Q?iSyYvNOljmjLEybhBkMlBq0Ta3ht8YrrEueWZkecxTljrC9rHsGXgkLH?= =?Windows-1252?Q?u5DRG1F1jqfoFOjRk41lb2JBY3qNfOS9RZHF6dapVet52Fppssd8tQGJ?= =?Windows-1252?Q?ysarSN715nB1urvxLB5pSTZ8Ng4aaQ=3D=3D;10:TsWobp/ekNxb6nKf?= =?Windows-1252?Q?VZnrnRe6SO3L4I0d3gWSS2G+1rjbPgUMbkGOLjbCWExAjW2oEMUUFYoN?= =?Windows-1252?Q?DClDejOV+ZIqvDF+48R1UTPuwm3yNtkTBO4=3D?= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB001; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN1BFFO11HUB001;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB001; X-Forefront-PRVS: 0574D4712B X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2015 06:06:40.6824 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2015 08:03 AM, Julia Lawall wrote: > On Tue, 12 May 2015, Michal Simek wrote: > >> DMA allocates skb->len instead of headlen >> which is used for DMA. >> >> Signed-off-by: Michal Simek >> --- >> >> drivers/net/ethernet/xilinx/ll_temac_main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c >> index ca640d04fd93..cfb6bdb37fdc 100644 >> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c >> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c >> @@ -705,8 +705,8 @@ static int temac_start_xmit(struct sk_buff *skb, struct net_device *ndev) >> >> cur_p->app0 |= STS_CTRL_APP0_SOP; >> cur_p->len = skb_headlen(skb); >> - cur_p->phys = dma_map_single(ndev->dev.parent, skb->data, skb->len, >> - DMA_TO_DEVICE); >> + cur_p->phys = dma_map_single(ndev->dev.parent, skb->data, >> + skb_headlen(skb), DMA_TO_DEVICE); > > I think you could align the later arguments with the right side of the > parenthesis, as done in the original code. Fixed and send v2. Thanks, Michal