public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kim, Milo" <milo.kim@ti.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>,
	Toshi Kikuchi <toshik@chromium.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org>,
	Bryan Wu <cooloney@gmail.com>
Subject: Re: [PATCH] leds: lp5523: add master_fader support
Date: Tue, 12 May 2015 17:25:29 +0900	[thread overview]
Message-ID: <5551B8F9.6040808@ti.com> (raw)
In-Reply-To: <5551AAFA.5080807@samsung.com>

Hi Jacek and Toshi,

On 5/12/2015 4:25 PM, Jacek Anaszewski wrote:
> Hi Toshi,
>
> On 05/11/2015 09:10 PM, Toshi Kikuchi wrote:
>> This patch introduces 4 new attributes:
>>     master_fader_leds
>>     master_fader1
>>     master_fader2
>>     master_fader3
>>
>> Fo example, to map channel 0,6 to master_fader1,
>> map channel 1,7 to master_fader2,
>> map channel 2,8 to master_fader3, and
>> map channel 3,4,5 to none
>   >
>>     echo "123000123" > master_fader_leds
>
> I propose to add ABI documentation for this driver. It already exposes
> many custom attributes but I can't find documentation for them.

I agree with Jacek's comment but it would be better if we could see the 
description in lp5523 driver 
documentation(Documentation/leds/leds-lp5523.txt).

Best regards,
Milo

  reply	other threads:[~2015-05-12  8:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 19:10 [PATCH] leds: lp5523: add master_fader support Toshi Kikuchi
2015-05-11 22:52 ` Kim, Milo
2015-05-12  7:25 ` Jacek Anaszewski
2015-05-12  8:25   ` Kim, Milo [this message]
2015-05-12  8:51     ` Jacek Anaszewski
2015-05-12 17:59       ` Bryan Wu
2015-06-22 11:58         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5551B8F9.6040808@ti.com \
    --to=milo.kim@ti.com \
    --cc=cooloney@gmail.com \
    --cc=j.anaszewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=toshik@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox