From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932833AbbELJgW (ORCPT ); Tue, 12 May 2015 05:36:22 -0400 Received: from foss.arm.com ([217.140.101.70]:60200 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932660AbbELJgR (ORCPT ); Tue, 12 May 2015 05:36:17 -0400 Message-ID: <5551C98D.6010104@arm.com> Date: Tue, 12 May 2015 10:36:13 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Viresh Kumar CC: Sudeep Holla , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jon Medhurst , "Rafael J. Wysocki" Subject: Re: [PATCH] cpufreq: arm_big_little: remove compile-time dependency on BL_SWITCHER References: <1431343473-9915-1-git-send-email-sudeep.holla@arm.com> <20150512072754.GF32300@linux> <5551B3C7.80004@arm.com> In-Reply-To: <5551B3C7.80004@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/15 09:03, Sudeep Holla wrote: > > > On 12/05/15 08:27, Viresh Kumar wrote: >> On 11-05-15, 12:24, Sudeep Holla wrote: >>> With the addition of switcher code, there's compile-time dependency on >>> BL_SWITCHER to get arm_big_little driver compiling on ARM64. Since ARM64 >> >> The Kconfig dependency isn't on the switcher but big.LITTLE, which >> isn't defined for arm64. So, we need a bit of clarity here. >> > > Right, we update accordingly. > >>> @@ -562,8 +580,7 @@ int bL_cpufreq_register(struct cpufreq_arm_bL_ops *ops) >>> >>> arm_bL_ops = ops; >>> >>> - ret = bL_switcher_get_enabled(); >>> - set_switching_enabled(ret); >>> + set_switching_enabled(bL_switcher_get_enabled()); >> >> This change wasn't required. >> > Right, I thought ret is not used anywhere else and might produce > warnings, which is wrong. I will revert it back. > Sorry replied too early, I have to retain it, or change it in bL_cpufreq_unregister as the stub produces warning in one of the 2 call sites since the return value is used in one place while discarded at another. Regards, Sudeep