From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/9] KVM: MMU: introduce for_each_rmap_spte()
Date: Tue, 12 May 2015 17:36:26 +0800 [thread overview]
Message-ID: <5551C99A.3020002@linux.intel.com> (raw)
In-Reply-To: <5551B4EE.8020000@redhat.com>
On 05/12/2015 04:08 PM, Paolo Bonzini wrote:
>
>
> On 12/05/2015 04:32, Xiao Guangrong wrote:
>> - while ((sptep = rmap_get_first(*rmapp, &iter))) {
>> - BUG_ON(!(*sptep & PT_PRESENT_MASK));
>> +restart:
>> + for_each_rmap_spte(rmapp, &iter, sptep) {
>> rmap_printk("kvm_rmap_unmap_hva: spte %p %llx gfn %llx (%d)\n",
>> sptep, *sptep, gfn, level);
>>
>> drop_spte(kvm, sptep);
>> need_tlb_flush = 1;
>> + goto restart;
>> }
>>
>
> For this one, I would keep using rmap_get_first. Otherwise looks good.
>
> Paolo
>
Okay, will do.
next prev parent reply other threads:[~2015-05-12 9:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 2:32 [PATCH v2 0/9] KVM: MTRR fixes and some cleanups Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 1/9] KVM: MMU: fix decoding cache type from MTRR Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 2/9] KVM: MMU: introduce for_each_rmap_spte() Xiao Guangrong
2015-05-12 8:08 ` Paolo Bonzini
2015-05-12 9:36 ` Xiao Guangrong [this message]
2015-05-12 2:32 ` [PATCH v2 3/9] KVM: MMU: introduce for_each_slot_rmap_range Xiao Guangrong
2015-05-12 8:22 ` Paolo Bonzini
2015-05-12 9:38 ` Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 4/9] KVM: MMU: introduce slot_handle_level_range() and its helpers Xiao Guangrong
2015-05-12 8:22 ` Paolo Bonzini
2015-05-12 9:37 ` Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 5/9] KVM: MMU: use slot_handle_level and its helper to clean up the code Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 6/9] KVM: MMU: introduce kvm_zap_rmapp Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 7/9] KVM: MMU: introduce kvm_zap_gfn_range Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 8/9] KVM: MMU: fix MTRR update Xiao Guangrong
2015-05-12 2:32 ` [PATCH v2 9/9] KVM: x86: do not reset mmu if CR0.CD and CR0.NW are changed Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5551C99A.3020002@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox