From: Denys Vlasenko <dvlasenk@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>,
Bart Van Assche <bvanassche@acm.org>,
Peter Zijlstra <peterz@infradead.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] force inlining of spinlock ops
Date: Tue, 12 May 2015 15:13:26 +0200 [thread overview]
Message-ID: <5551FC76.40000@redhat.com> (raw)
In-Reply-To: <20150512114353.GA13699@gmail.com>
On 05/12/2015 01:43 PM, Ingo Molnar wrote:
>>> Furtermore, what is the size win on x86 defconfig with these options
>>> set?
>>
>> CONFIG_OPTIMIZE_INLINING=y is in defconfig.
>>
>> Size difference for CC_OPTIMIZE_FOR_SIZE:
>>
>> text data bss dec hex filename
>> 12335864 1746152 1081344 15163360 e75fe0 vmlinux.CC_OPTIMIZE_FOR_SIZE=y
>> 10373764 1684200 1077248 13135212 c86d6c vmlinux.CC_OPTIMIZE_FOR_SIZE=n
>>
>> Decrease by about 19%.
>
> I suspect the 'filename' field wants to be flipped?
Yes.
> In any case, the interesting measurement would not be -Os comparisons
> (which causes GCC to be too crazy), but to see the size effect of your
> _patch_ that always-inlines spinlock ops, on plain defconfig and on
> defconfig-Os.
Here it is:
text data bss dec hex filename
12335864 1746152 1081344 15163360 e75fe0 vmlinuxO2.before
12335930 1746152 1081344 15163426 e76022 vmlinux
text data bss dec hex filename
10373764 1684200 1077248 13135212 c86d6c vmlinuxOs.before
10363621 1684200 1077248 13125069 c845cd vmlinux
next prev parent reply other threads:[~2015-05-12 13:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 17:57 [PATCH] force inlining of spinlock ops Denys Vlasenko
2015-05-11 18:53 ` Josh Triplett
2015-05-11 22:19 ` Andrew Morton
2015-05-12 8:16 ` Hagen Paul Pfeifer
2015-05-12 9:44 ` Denys Vlasenko
2015-05-12 9:48 ` Ingo Molnar
2015-05-12 7:44 ` Ingo Molnar
2015-05-12 11:02 ` Denys Vlasenko
2015-05-12 11:43 ` Ingo Molnar
2015-05-12 13:13 ` Denys Vlasenko [this message]
2015-05-13 10:17 ` Ingo Molnar
2015-05-13 10:28 ` Denys Vlasenko
2015-05-13 10:43 ` Ingo Molnar
2015-05-13 14:09 ` Denys Vlasenko
2015-05-15 7:20 ` Heiko Carstens
-- strict thread matches above, loose matches on Subject: below --
2015-07-13 18:31 Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5551FC76.40000@redhat.com \
--to=dvlasenk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tgraf@suug.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).