From: Stephen Boyd <sboyd@codeaurora.org>
To: John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org
Cc: Kumar Gala <galak@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [RFC][PATCH] devicetree: Add hardware rng entry to qcom-apq8064.dtsi
Date: Tue, 12 May 2015 11:52:40 -0700 [thread overview]
Message-ID: <55524BF8.1050200@codeaurora.org> (raw)
In-Reply-To: <1431453201-29066-1-git-send-email-john.stultz@linaro.org>
On 05/12/15 10:53, John Stultz wrote:
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index b3154c0..c760f2f 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -226,6 +226,13 @@
> };
> };
>
> + rng@1a500000 {
> + compatible = "qcom,prng";
> + reg = <0x1A500000 0x200>;
This could be lowercase to match the rest of this file.
> + clocks = <&gcc PRNG_CLK>;
> + clock-names = "core";
> + };
> +
> qcom,ssbi@500000 {
> compatible = "qcom,ssbi";
> reg = <0x00500000 0x1000>;
Otherwise looks good.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-05-12 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:53 [RFC][PATCH] devicetree: Add hardware rng entry to qcom-apq8064.dtsi John Stultz
2015-05-12 18:52 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55524BF8.1050200@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox