From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933897AbbELSwp (ORCPT ); Tue, 12 May 2015 14:52:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34008 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933069AbbELSwl (ORCPT ); Tue, 12 May 2015 14:52:41 -0400 Message-ID: <55524BF8.1050200@codeaurora.org> Date: Tue, 12 May 2015 11:52:40 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: John Stultz , linux-kernel@vger.kernel.org CC: Kumar Gala , Srinivas Kandagatla , devicetree@vger.kernel.org Subject: Re: [RFC][PATCH] devicetree: Add hardware rng entry to qcom-apq8064.dtsi References: <1431453201-29066-1-git-send-email-john.stultz@linaro.org> In-Reply-To: <1431453201-29066-1-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/15 10:53, John Stultz wrote: > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index b3154c0..c760f2f 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -226,6 +226,13 @@ > }; > }; > > + rng@1a500000 { > + compatible = "qcom,prng"; > + reg = <0x1A500000 0x200>; This could be lowercase to match the rest of this file. > + clocks = <&gcc PRNG_CLK>; > + clock-names = "core"; > + }; > + > qcom,ssbi@500000 { > compatible = "qcom,ssbi"; > reg = <0x00500000 0x1000>; Otherwise looks good. Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project