From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933240AbbELTWO (ORCPT ); Tue, 12 May 2015 15:22:14 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:40823 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683AbbELTWN (ORCPT ); Tue, 12 May 2015 15:22:13 -0400 Message-ID: <555252CB.3010208@ti.com> Date: Tue, 12 May 2015 14:21:47 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mark Brown CC: Michael Welling , , , , , Subject: Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs References: <1431452337-19280-1-git-send-email-mwelling@ieee.org> <55524D20.2050203@ti.com> <20150512191905.GY3066@sirena.org.uk> In-Reply-To: <20150512191905.GY3066@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2015 02:19 PM, Mark Brown wrote: > On Tue, May 12, 2015 at 01:57:36PM -0500, Nishanth Menon wrote: >> On 05/12/2015 12:38 PM, Michael Welling wrote: >>> GPIO chip select patch series appears to have broken the native chip select >>> support. This patch pulls the manual native chip select toggling out of >>> the transfer_one routine and adds a set_cs routine. > > Please remember to delete unneeded context from your replies, the reader > shouldn't need to page through the entire patch to find out you reviewed > it. Will do so. Anyways, I did test it to be accurate - have'nt reviewed it. -- Regards, Nishanth Menon