From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753261AbbELTwK (ORCPT ); Tue, 12 May 2015 15:52:10 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:35869 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbbELTwF (ORCPT ); Tue, 12 May 2015 15:52:05 -0400 Message-ID: <555259E1.8010908@gmail.com> Date: Tue, 12 May 2015 21:52:01 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Greg KH CC: dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/33] staging: rtl8192e: Fix PREFER_ETHER_ADDR_COPY warnings References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-3-git-send-email-mateusz.kulikowski@gmail.com> <20150510131955.GA10427@kroah.com> In-Reply-To: <20150510131955.GA10427@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.05.2015 15:19, Greg KH wrote: > On Sat, May 09, 2015 at 11:18:50PM +0200, Mateusz Kulikowski wrote: >> Replace memcpy() with ether_addr_copy() where possible to make >> checkpatch.pl happy. > > I need proof that this is ok to do, please provide that in the changelog > entry. What kind of proof do you expect? I've added BUG into ether_addr_copy (on unaligned addresses) and did some basic networking tests (pings using WPA2/CCMP AP). Of course I haven't done 100% coverage test to driver. Additionally I manually analyzed code (although human errors are possible). Do you want me to run some static analyzer as well? Or are this two enough (just add them to changelog). Regards, Mateusz