From: Ed Cashin <ed.cashin@acm.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tina Ruchandani <ruchandani.tina@gmail.com>,
y2038@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aoe: Use 64-bit timestamp in frame
Date: Tue, 12 May 2015 21:26:35 -0400 [thread overview]
Message-ID: <5552A84B.3020707@acm.org> (raw)
In-Reply-To: <2498255.lB0xaQWuiu@wuerfel>
On 05/12/2015 05:44 AM, Arnd Bergmann wrote:
> On Monday 11 May 2015 21:00:25 Ed Cashin wrote:
...
> In that case, there is still information about the timing embedded in
> the AoE tag. The send time in jiffies is a rough-grained record of the
> send time, and it's extracted from the tag. For these "unexpected"
> responses, this timing information can improve performance significantly
> without introducing extra overhead or risk.
> That path is not changed at all by this patch, right? It also looks
> like the jiffies information from there is only used to print an
> error message.
>
That's right, thanks, the tag still has the old jiffies embedded
in it.
The information, though, is used to update the round-trip-time
average and the running estimate of the RTT variance. For the
unexpected responses that information can help the driver to
maintain high performance when there are inconsistencies in the
network performance. (calc_rttavg)
--
Ed
prev parent reply other threads:[~2015-05-13 1:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 2:35 [PATCH] aoe: Use 64-bit timestamp in frame Tina Ruchandani
2015-05-11 15:38 ` Arnd Bergmann
2015-05-11 15:59 ` Ed Cashin
2015-05-12 1:00 ` Ed Cashin
2015-05-12 9:44 ` Arnd Bergmann
2015-05-12 11:14 ` [Y2038] " Arnd Bergmann
2015-05-13 1:23 ` Ed Cashin
2015-05-13 8:04 ` Arnd Bergmann
2015-05-14 0:47 ` Ed Cashin
2015-05-12 11:21 ` Ed Cashin
2015-05-13 1:26 ` Ed Cashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5552A84B.3020707@acm.org \
--to=ed.cashin@acm.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ruchandani.tina@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox