From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932936AbbEMIQX (ORCPT ); Wed, 13 May 2015 04:16:23 -0400 Received: from smtp81.iad3a.emailsrvr.com ([173.203.187.81]:46693 "EHLO smtp81.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbbEMIQU (ORCPT ); Wed, 13 May 2015 04:16:20 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <55530854.1030004@mev.co.uk> Date: Wed, 13 May 2015 09:16:20 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Tolga Ceylan , H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers: staging: comedi: drivers: ni_mio_common.c: removed no-effect right hand operand References: <1431492833-14711-1-git-send-email-tolga.ceylan@gmail.com> In-Reply-To: <1431492833-14711-1-git-send-email-tolga.ceylan@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/05/15 05:53, Tolga Ceylan wrote: > In ni_ai_cmd() bitwise or construction of ai_trig in case of TRIG_NOW > is faulty. Register address is accidentally in the expression, > but this has no effect. This is an accidental left-over code > that used to call a function with register address as one of > the arguments. > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/comedi/drivers/ni_mio_common.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c > index c741dde..9dfd4e6 100644 > --- a/drivers/staging/comedi/drivers/ni_mio_common.c > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c > @@ -2268,8 +2268,7 @@ static int ni_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) > case TRIG_INT: > case TRIG_NOW: > ai_trig |= NISTC_AI_TRIG_START1_EDGE | > - NISTC_AI_TRIG_START1_SEL(0), > - NISTC_AI_TRIG_SEL_REG; > + NISTC_AI_TRIG_START1_SEL(0); > break; > case TRIG_EXT: > ai_trig |= NISTC_AI_TRIG_START1_SEL(CR_CHAN(cmd->start_arg) + > Thanks. The patch is fine, but Hartley has already sent the same fix to , and Greg was intending to apply that one. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-