Re: [PATCH v4 08/11] mtd: brcmnand: add BCM63138 support

Arnd Bergmann
2015-05-13T20:03:29Z

On Wednesday 13 May 2015 12:45:21 Brian Norris wrote:
> On Wed, May 13, 2015 at 12:49:01PM +0200, Arnd Bergmann wrote:
> > On Tuesday 12 May 2015 17:53:41 Brian Norris wrote:
> >
> > This is a slightly unconventional method of doing the abstraction.
> > For consistency with a lot of other drivers, I'd do it like this:
> >
> > struct bcm63138_controller {
> > void __iomem *base;
> > brcmnand_controller parent;
> > };
>
> Does it really make sense to publicize all of the brcmnand_controller
> details to each of the constituent drivers? I was intentionally keeping
> them private, with a very small and well-defined interface provided for
> shim SoC drivers.
>
> This is kind of a problem that has plagued the wider MTD (and esp. NAND)
> subsystem in general; we expose a ton of details to low-level drivers,
> and they're free to muck with things however they want, as long as it
> ends up working. I'd rather be more intentional in what I expose.

In most cases like this, the soc-specific glue drivers eventually need
access to some of the struct members anyway, but of course it's possible
that you don't need that here.

> > static bool bcm63138_nand_intc_ack(struct brcmnand_controller *parent)
> > {
> > struct bcm63138_controller *controller;
> > controller = container_of(parent, struct brcmnand_controller, parent);
> >
> > ...
> > }
> >
> > static int bcm63138_nand_probe(...)
> > {
> > struct bcm63138_controller *controller;
> >
> > controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL);
> > ...
> > return brcmnand_probe(pdev, &controller->parent);
> > }
> >
> > This also simplifies the probe() functions and means less pointer chasing.
>
> I could still avoid one pointer chase and one extra memory allocation by
> embedding 'struct brcmnand_soc' in a 'struct bcm63138_nand_soc'. e.g.:
>
> struct bcm63138_nand_soc {
> void __iomem *base;
> struct brcmnand_soc soc;
> };
>
> static bool bcm63138_nand_intc_ack(struct brcmnand_soc *soc)
> {
> struct bcm63138_nand_soc *priv;
> priv = container_of(soc, struct bcm63138_nand_soc, soc);
>
> ...
> }
>
> static int bcm63138_nand_probe(...)
> {
> struct bcm63138_nand_soc *priv;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> ...
> return brcmnand_probe(pdev, &priv->soc);
> }

That would make struct brcmnand_soc an empty structure, right?
I think that's fine though, at least it avoids passing void pointers
and it avoids one of the two allocations you do.

There is another variation of this model, which some drivers use:

static int bcm63138_nand_probe(...)
{
struct bcm63138_nand_soc *priv;
struct brcmnand_controller *controller;

controller = brcmnand_controller_alloc(dev, sizeof (*priv));

priv = brcmnand_controller_priv(controller);

...

return brcmnand_register(controller);
}

struct brcmnand_controller *brcmnand_controller_alloc(struct device *pdev, size_t extra)
{
struct brcmnand_controller *p = dev_kzalloc(dev, sizeof(*p) + extra);

...

return p;
}

void *brcmnand_controller_priv(brcmnand_controller *p)
{
/* extra data follows at the next byte after the controller structure */
return p + 1;
}

Some subsystem maintainers prefer this model over the other one, up to you.

Arnd