From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias
Date: Thu, 14 May 2015 09:37:51 +0900 [thread overview]
Message-ID: <5553EE5F.7030105@samsung.com> (raw)
In-Reply-To: <1431563551-9461-1-git-send-email-javier.martinez@collabora.co.uk>
On 14.05.2015 09:32, Javier Martinez Canillas wrote:
> If the pwm-samsung driver is built as a module, modalias information is
> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
> macro to export the OF device ID so the module contains that information.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
I think many other Maxim/S[25]M drivers for Samsung boards may also be
affected... Probably they should also be updated.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-05-14 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 0:32 [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias Javier Martinez Canillas
2015-05-14 0:37 ` Krzysztof Kozlowski [this message]
2015-05-14 0:47 ` Javier Martinez Canillas
2015-05-21 8:13 ` Javier Martinez Canillas
2015-05-21 8:20 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5553EE5F.7030105@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox