From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933763AbbENSqP (ORCPT ); Thu, 14 May 2015 14:46:15 -0400 Received: from smtp-out-168.synserver.de ([212.40.185.168]:1051 "EHLO smtp-out-168.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933129AbbENSqN (ORCPT ); Thu, 14 May 2015 14:46:13 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 4580 Message-ID: <5554ED71.4040608@metafoo.de> Date: Thu, 14 May 2015 20:46:09 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Mark Brown , "Maciej S. Szmigiero" CC: alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Brian Austin , Bard Liao , Oder Chiou , Wolfram Sang , linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config References: <554E8634.2010008@maciej.szmigiero.name> <20150512175807.GL3066@sirena.org.uk> <5553BAB4.3040209@maciej.szmigiero.name> <20150514175351.GQ2761@sirena.org.uk> In-Reply-To: <20150514175351.GQ2761@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/14/2015 07:53 PM, Mark Brown wrote: > On Wed, May 13, 2015 at 10:57:24PM +0200, Maciej S. Szmigiero wrote: >> W dniu 12.05.2015 19:58, Mark Brown pisze: >>> On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: > >>>> @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS >>>> select SND_SOC_88PM860X if MFD_88PM860X >>>> select SND_SOC_L3 >>>> select SND_SOC_AB8500_CODEC if ABX500_CORE >>>> - select SND_SOC_AC97_CODEC if SND_SOC_AC97_BUS >>>> + select SND_SOC_AC97_CODEC >>>> select SND_SOC_AD1836 if SPI_MASTER >>>> select SND_SOC_AD193X_SPI if SPI_MASTER >>>> select SND_SOC_AD193X_I2C if I2C > >>> No, you're missing the point of what _ALL_CODECS does - it builds >>> everything possible. This will break the build for systems without >>> AC'97 support. > >> How? >> In the second hunk of the patch I've made SND_SOC_AC97_CODEC select >> SND_SOC_AC97_BUS. > > select doesn't respect dependencies, it'll just force on the selected > symbol. The patch works fine, neither SND_SOC_AC97_BUS nor the symbols selected by SND_SOC_AC97_BUS have any dependencies. Although one might argue that only AC97 host driver should select SND_SOC_AC97_BUS and the CODEC drivers should depend on it. - Lars