From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Brian Austin <brian.austin@cirrus.com>,
Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config
Date: Thu, 14 May 2015 21:24:15 +0200 [thread overview]
Message-ID: <5554F65F.7090004@metafoo.de> (raw)
In-Reply-To: <20150514191031.GS2761@sirena.org.uk>
On 05/14/2015 09:10 PM, Mark Brown wrote:
> On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote:
>> On 05/14/2015 07:53 PM, Mark Brown wrote:
>
>>> select doesn't respect dependencies, it'll just force on the selected
>>> symbol.
>
>> The patch works fine, neither SND_SOC_AC97_BUS nor the symbols selected by
>> SND_SOC_AC97_BUS have any dependencies.
>
> Does the select from SND_SOC_AC97_BUS actually happen if it is selected
> by SND_SOC_ALL_CODECS? That's the issue, if it works now it's a
> relatively recent thing.
I'm not sure I fully understand what you mean.
The Kconfig entry for the CODEC has no 'depends on'. It does a 'select
SND_SOC_AC97_BUS', which means all built time dependencies are pulled in
this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that
should work fine, since no dependencies are bypassed.
next prev parent reply other threads:[~2015-05-14 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 22:12 [PATCH] ASoC: codecs-ac97: make selectable in config Maciej S. Szmigiero
2015-05-12 17:58 ` Mark Brown
2015-05-13 20:57 ` Maciej S. Szmigiero
2015-05-14 17:53 ` Mark Brown
2015-05-14 18:46 ` Lars-Peter Clausen
2015-05-14 19:10 ` Mark Brown
2015-05-14 19:24 ` Lars-Peter Clausen [this message]
2015-05-14 19:28 ` Mark Brown
2015-05-14 19:38 ` Lars-Peter Clausen
2015-05-14 19:43 ` Mark Brown
2015-05-22 12:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554F65F.7090004@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox