From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965059AbbENTYV (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 May 2015 15:24:21 -0400
Received: from smtp-out-168.synserver.de ([212.40.185.168]:1048 "EHLO
	smtp-out-168.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964849AbbENTYU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 May 2015 15:24:20 -0400
X-SynServer-TrustedSrc: 1
X-SynServer-AuthUser: lars@metafoo.de
X-SynServer-PPID: 19003
Message-ID: <5554F65F.7090004@metafoo.de>
Date: Thu, 14 May 2015 21:24:15 +0200
From: Lars-Peter Clausen <lars@metafoo.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: Mark Brown <broonie@kernel.org>
CC: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
        alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
        Brian Austin <brian.austin@cirrus.com>,
        Bard Liao <bardliao@realtek.com>, Oder Chiou <oder_chiou@realtek.com>,
        Wolfram Sang <wsa@the-dreams.de>, linux-kernel@vger.kernel.org,
        Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config
References: <554E8634.2010008@maciej.szmigiero.name> <20150512175807.GL3066@sirena.org.uk> <5553BAB4.3040209@maciej.szmigiero.name> <20150514175351.GQ2761@sirena.org.uk> <5554ED71.4040608@metafoo.de> <20150514191031.GS2761@sirena.org.uk>
In-Reply-To: <20150514191031.GS2761@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/14/2015 09:10 PM, Mark Brown wrote:
> On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote:
>> On 05/14/2015 07:53 PM, Mark Brown wrote:
>
>>> select doesn't respect dependencies, it'll just force on the selected
>>> symbol.
>
>> The patch works fine, neither SND_SOC_AC97_BUS nor the symbols selected by
>> SND_SOC_AC97_BUS have any dependencies.
>
> Does the select from SND_SOC_AC97_BUS actually happen if it is selected
> by SND_SOC_ALL_CODECS?  That's the issue, if it works now it's a
> relatively recent thing.

I'm not sure I fully understand what you mean.

The Kconfig entry for the CODEC has no 'depends on'. It does a 'select 
SND_SOC_AC97_BUS', which means all built time dependencies are pulled in 
this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that 
should work fine, since no dependencies are bypassed.