From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Brown <broonie@kernel.org>,
Jonathan Richardson <jonathar@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>,
Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.
Date: Thu, 14 May 2015 14:43:14 -0700 [thread overview]
Message-ID: <555516F2.6080201@gmail.com> (raw)
In-Reply-To: <20150514201221.GX2761@sirena.org.uk>
On 14/05/15 13:12, Mark Brown wrote:
> On Thu, May 14, 2015 at 12:55:32PM -0700, Jonathan Richardson wrote:
>> On 15-05-14 12:08 PM, Mark Brown wrote:
>
>>> All it takes is one hardware engineer who sees a SPI controller and a
>>> GPIO they can use for chip select; I wouldn't be so sure that nobody
>>> ever fixed this up locally (or happened to use a device that only needed
>>> single duplex).
>
>> Hi Mark. Would it help if we just set the flags to half duplex using
>> SPI_MASTER_HALF_DUPLEX when we register the master?
>
> That would deal with the data corruption issues, yes. Though it seems
> like there are some people who want full duplex support here - I don't
> know if any of them can point you at suitable hardware to test?
I am fine with having the driver supporting only half-duplex for now,
considering that Jonathan and Scott have no peripheral to test
full-duplex with.
Getting you platforms and test setups could take more time than needed
so, let's proceed with the shortest path.
--
Florian
prev parent reply other threads:[~2015-05-14 21:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:38 [PATCH 0/2] Add Broadcom MSPI driver Jonathan Richardson
2015-05-12 17:38 ` [PATCH 1/2] ARM: dts: Add binding for " Jonathan Richardson
2015-05-12 18:38 ` Florian Fainelli
2015-05-12 17:38 ` [PATCH 2/2] spi: bcm-mspi: Add support " Jonathan Richardson
2015-05-12 18:46 ` Florian Fainelli
2015-05-12 19:17 ` Mark Brown
2015-05-13 23:49 ` Jonathan Richardson
2015-05-14 0:19 ` Scott Branden
2015-05-14 10:31 ` Mark Brown
2015-05-14 18:19 ` Scott Branden
2015-05-14 18:28 ` Florian Fainelli
2015-05-14 18:36 ` Scott Branden
2015-05-14 18:55 ` Jonathan Richardson
2015-05-14 19:08 ` Mark Brown
2015-05-14 19:55 ` Jonathan Richardson
2015-05-14 20:12 ` Mark Brown
2015-05-14 21:43 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555516F2.6080201@gmail.com \
--to=f.fainelli@gmail.com \
--cc=anatol@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dtor@google.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathar@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox