From: He Kuang <hekuang@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: hekuang <hekuang@zoho.com>, <acme@kernel.org>, <jolsa@kernel.org>,
<mingo@redhat.com>, <a.p.zijlstra@chello.nl>,
<wangnan0@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins
Date: Fri, 15 May 2015 16:01:30 +0800 [thread overview]
Message-ID: <5555A7DA.2090800@huawei.com> (raw)
In-Reply-To: <20150514133105.GC1313@krava.redhat.com>
On 2015/5/14 21:31, Jiri Olsa wrote:
> On Thu, May 14, 2015 at 08:56:15PM +0800, He Kuang wrote:
>
> SNIP
>
>>>> It seems new targets are needed. In the v2 patch,
>>>
>>> hum, I dont get it.. why ?
>>>
>>> dynamic-list-file gets rebuilt any time plugins are rebuilt..
>>> why not keep just the 'plugins' dependency?
>>
>> You can test your patch as following steps:
>>
>> $ touch ../lib/traceevent/plugin_function.c
>> $ make
>> CC plugin_function.o
>> LD plugin_function-in.o
>> LINK plugin_function.so
>> GEN libtraceevent-dynamic-list
>>
>> perf is not rebuilt. There should be a 'GEN perf', right?
>
> hum, right.. so this is separated bug that was there even
> without your change. I tried to kick my change to address
> that and ended up with what you sent in v2 ;-)
>
> I have another comment for your v2, which I'll send right away
>
> thanks,
> jirka
>
Ok, please review the new version.
next prev parent reply other threads:[~2015-05-15 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 6:41 [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins He Kuang
2015-05-12 6:41 ` [PATCH v2 2/2] tools lib traceevent: Ignore libtrace-dynamic-list file He Kuang
2015-05-12 12:37 ` [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins Jiri Olsa
2015-05-12 15:25 ` hekuang
2015-05-13 14:50 ` Jiri Olsa
2015-05-14 12:56 ` He Kuang
2015-05-14 13:31 ` Jiri Olsa
2015-05-15 8:01 ` He Kuang [this message]
2015-05-14 13:33 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5555A7DA.2090800@huawei.com \
--to=hekuang@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=hekuang@zoho.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox